Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix js-framework-benchmark CI #520

Merged
merged 9 commits into from
Oct 31, 2022
Merged

Fix js-framework-benchmark CI #520

merged 9 commits into from
Oct 31, 2022

Conversation

lukechu10
Copy link
Collaborator

No description provided.

@lukechu10 lukechu10 added the performance Performance related label Oct 30, 2022
@github-actions
Copy link

Started a benchmark for this pull request.
This comment will be updated with the results.
Workflow: 3355394280
Adding new commits will generate a new report

@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Base: 64.69% // Head: 64.69% // No change to project coverage 👍

Coverage data is based on head (8a8e339) compared to base (abd556c).
Patch has no changes to coverable lines.

❗ Current head 8a8e339 differs from pull request most recent head 23665d3. Consider uploading reports for the commit 23665d3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #520   +/-   ##
=======================================
  Coverage   64.69%   64.69%           
=======================================
  Files          52       52           
  Lines        8537     8537           
=======================================
  Hits         5523     5523           
  Misses       3014     3014           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 30, 2022

The benchmark failed to complete.
Please see the workflow for more details.
Workflow: 3355417756
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Oct 30, 2022

Finished dev [unoptimized + debuginfo] target(s) in 0.04s
 Running `/home/runner/work/sycamore/sycamore/sycamore/target/debug/bench-diff ../../../../js-framework-benchmark/webdriver-ts/results.json`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                           Performance Diff                           @@

##                          | wasm-bindgen | baseline |  update |  diff ##
##########################################################################
  01_run1k                  |       101.69 |     0.00 |    0.00 |     NaN%
  02_replace1k              |       104.33 |     0.00 |    0.00 |     NaN%
  03_update10th1k_x16       |       253.81 |     0.00 |    0.00 |     NaN%
  04_select1k               |        33.04 |     0.00 |    0.00 |     NaN%
  05_swap1k                 |        66.34 |     0.00 |    0.00 |     NaN%
  06_remove-one-1k          |       114.85 |     0.00 |    0.00 |     NaN%
  07_create10k              |      1058.94 |     0.00 |    0.00 |     NaN%
  08_create1k-after1k_x2    |       234.14 |     0.00 |    0.00 |     NaN%
  09_clear1k_x8             |        73.37 |     0.00 |    0.00 |     NaN%
  21_ready-memory           |         2.17 |     0.00 |    0.00 |     NaN%
  22_run-memory             |         3.16 |     0.00 |    0.00 |     NaN%
  23_update5-memory         |         3.33 |     0.00 |    0.00 |     NaN%
  25_run-clear-memory       |         2.23 |     0.00 |    0.00 |     NaN%
  26_run-10k-memory         |        13.80 |     0.00 |    0.00 |     NaN%
  31_startup-ci             |      1879.25 |     0.00 |    0.00 |     NaN%
  32_startup-bt             |         0.00 |     0.00 |    0.00 |     NaN%
  33_startup-mainthreadcost |        13.02 |     0.00 |    0.00 |     NaN%
  34_startup-totalbytes     |       189.33 |     0.00 |    0.00 |     NaN%

Workflow: 3355439951
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Oct 30, 2022

Finished dev [unoptimized + debuginfo] target(s) in 0.05s
 Running `/home/runner/work/sycamore/sycamore/sycamore/target/debug/bench-diff ../../../../js-framework-benchmark/webdriver-ts/results.json`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                           Performance Diff                           @@

##                          | wasm-bindgen | baseline |  update |  diff ##
##########################################################################
  01_run1k                  |       127.50 |     0.00 |    0.00 |     NaN%
  02_replace1k              |       137.00 |     0.00 |    0.00 |     NaN%
  03_update10th1k_x16       |       363.92 |     0.00 |    0.00 |     NaN%
  04_select1k               |        58.00 |     0.00 |    0.00 |     NaN%
  05_swap1k                 |       104.91 |     0.00 |    0.00 |     NaN%
  06_remove-one-1k          |       181.43 |     0.00 |    0.00 |     NaN%
  07_create10k              |      1347.80 |     0.00 |    0.00 |     NaN%
  08_create1k-after1k_x2    |       320.59 |     0.00 |    0.00 |     NaN%
  09_clear1k_x8             |        94.99 |     0.00 |    0.00 |     NaN%
  21_ready-memory           |         2.16 |     0.00 |    0.00 |     NaN%
  22_run-memory             |         3.16 |     0.00 |    0.00 |     NaN%
  23_update5-memory         |         3.32 |     0.00 |    0.00 |     NaN%
  25_run-clear-memory       |         2.23 |     0.00 |    0.00 |     NaN%
  26_run-10k-memory         |        13.80 |     0.00 |    0.00 |     NaN%
  31_startup-ci             |      1880.92 |     0.00 |    0.00 |     NaN%
  32_startup-bt             |         0.00 |     0.00 |    0.00 |     NaN%
  33_startup-mainthreadcost |        17.87 |     0.00 |    0.00 |     NaN%
  34_startup-totalbytes     |       189.33 |     0.00 |    0.00 |     NaN%

Workflow: 3355484451
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Oct 30, 2022

Finished dev [unoptimized + debuginfo] target(s) in 0.06s
 Running `/home/runner/work/sycamore/sycamore/sycamore/target/debug/bench-diff ../../../../js-framework-benchmark/webdriver-ts/results.json`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                           Performance Diff                           @@

##                          | wasm-bindgen | baseline |  update |  diff ##
##########################################################################
  01_run1k                  |       152.90 |     0.00 |    0.00 |     NaN%
  02_replace1k              |       160.31 |     0.00 |    0.00 |     NaN%
  03_update10th1k_x16       |       361.83 |     0.00 |    0.00 |     NaN%
  04_select1k               |        47.48 |     0.00 |    0.00 |     NaN%
  05_swap1k                 |        99.58 |     0.00 |    0.00 |     NaN%
  06_remove-one-1k          |       190.79 |     0.00 |    0.00 |     NaN%
  07_create10k              |      1620.24 |     0.00 |    0.00 |     NaN%
  08_create1k-after1k_x2    |       372.56 |     0.00 |    0.00 |     NaN%
  09_clear1k_x8             |       104.87 |     0.00 |    0.00 |     NaN%
  21_ready-memory           |         2.16 |     0.00 |    0.00 |     NaN%
  22_run-memory             |         3.16 |     0.00 |    0.00 |     NaN%
  23_update5-memory         |         3.33 |     0.00 |    0.00 |     NaN%
  25_run-clear-memory       |         2.23 |     0.00 |    0.00 |     NaN%
  26_run-10k-memory         |        13.80 |     0.00 |    0.00 |     NaN%
  31_startup-ci             |      1881.94 |     0.00 |    0.00 |     NaN%
  32_startup-bt             |         0.00 |     0.00 |    0.00 |     NaN%
  33_startup-mainthreadcost |        30.60 |     0.00 |    0.00 |     NaN%
  34_startup-totalbytes     |       189.33 |     0.00 |    0.00 |     NaN%

Workflow: 3355529815
Adding new commits will generate a new report

@lukechu10
Copy link
Collaborator Author

Wait why is there somebody else on the commits as well lol...

@lukechu10 lukechu10 marked this pull request as ready for review October 31, 2022 18:29
@lukechu10 lukechu10 merged commit 5eff5ca into master Oct 31, 2022
@lukechu10 lukechu10 deleted the fix-js-bench branch October 31, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants