Avoid exponential blowup in size of Builder type #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the comment added to builder.rs for the juicy details, but the tl;dr is that by *not* calling a shared internal function in the various `ElementBuilder` entrypoints, we avoid an exponential explosion in the size of the resulting Builder object type and thereby dodge limits on mangled symbol size.
sapphire-arches
force-pushed
the
avoid-exponential-builder
branch
from
18b280a
to
067f336
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #591 +/- ##
==========================================
- Coverage 60.82% 60.52% -0.30%
==========================================
Files 56 56
Lines 9340 9396 +56
==========================================
+ Hits 5681 5687 +6
- Misses 3659 3709 +50
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
lukechu10
approved these changes
Mar 25, 2023
|
This commit took our build time from 11 mins to 3.5. Appreciate it! Details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the comment added to builder.rs for the juicy details, but the tl;dr is that by not calling a shared internal function in the various
ElementBuilderentrypoints, we avoid an exponential explosion in the size of the resulting Builder object type and thereby dodge limits on mangled symbol size.An alternative solution would be recommending using
v0name mangling (RUSTFLAGS=-Csymbol-mangling-version=v0) but that seems less convenient for users and anyway we should probably avoid generating exponential types in case the compiler takes a peek and gets very sad and slow.This is kind of hard to add an automatic (stress) test for, as testing requires poking the generated
.wasmfile to see if any of the mangled names are looking exponential-ish.