Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builder bind_value and bind_checked calling wasm functions in SSR #608

Merged
merged 1 commit into from
May 4, 2023

Conversation

lukechu10
Copy link
Collaborator

Fixes #607

@lukechu10 lukechu10 added C-bug Category: bug, something isn't working A-SSR Area: Server Side Rendering (SSR) and Static Site Generation (SSG) A-builder Area: builder API labels May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (3885a9e) 60.52% compared to head (cbcd4ef) 60.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
- Coverage   60.52%   60.45%   -0.07%     
==========================================
  Files          56       54       -2     
  Lines        9380     9371       -9     
==========================================
- Hits         5677     5665      -12     
- Misses       3703     3706       +3     
Impacted Files Coverage Δ
packages/sycamore/src/builder.rs 22.78% <0.00%> (-0.10%) ⬇️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lukechu10 lukechu10 merged commit 6fc3eff into sycamore-rs:master May 4, 2023
@lukechu10 lukechu10 deleted the fix-builder-bind-on-ssr branch November 5, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-builder Area: builder API A-SSR Area: Server Side Rendering (SSR) and Static Site Generation (SSG) C-bug Category: bug, something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builder version input().bind_value(...) has requirements that the view! macro doesn't
1 participant