Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition in Suspense is not reactive breaking hydration #735

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

lukechu10
Copy link
Collaborator

No description provided.

@lukechu10 lukechu10 added C-bug Category: bug, something isn't working A-async Area: futures, suspense, and async/await labels Oct 20, 2024
@lukechu10 lukechu10 enabled auto-merge (squash) October 20, 2024 20:42
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.84%. Comparing base (4573c19) to head (810db7c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #735   +/-   ##
=======================================
  Coverage   71.84%   71.84%           
=======================================
  Files          44       44           
  Lines        6282     6282           
=======================================
  Hits         4513     4513           
  Misses       1769     1769           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukechu10 lukechu10 merged commit eeaf25d into sycamore-rs:main Oct 20, 2024
12 checks passed
@lukechu10 lukechu10 deleted the fix-suspense-hydrate branch November 5, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-async Area: futures, suspense, and async/await C-bug Category: bug, something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant