Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode styling #10

Closed
wants to merge 1 commit into from

Conversation

extremelyonline
Copy link
Contributor

@extremelyonline extremelyonline commented Dec 16, 2023

Hello, this PR add dark mode styling:

  • Put all colors into variables, defined in base.css
  • Pure css, use prefers-color-scheme to set light/dark mode
  • Light and dark mode share the same primary color #6b7280, svg colors are unchanged
  • Dark mode colors are in the same shade as #6b7280
  • Remove all box shadows in dark mode
  • There is no toggle button (yet)
  • Perhaps an environment variable to force light/dark mode can be added?

Closes #22

@syeopite
Copy link
Owner

Thanks this is awesome! I'll take a closer look at this soon but do you mind if this is pushed to the next release?

I'm planning on having a proper "0.1.0" release in the coming days so I'll only be doing bug fixes for now.

I'd like for this to be a "0.2.0" feature which should hopefully come with a settings page that'd go nicely along with this feature.

@syeopite syeopite mentioned this pull request Feb 6, 2024
@extremelyonline extremelyonline marked this pull request as ready for review February 21, 2024 02:49
@syeopite
Copy link
Owner

syeopite commented Jun 8, 2024

Hello,

Sorry about the inconvenience but I'm superseding this PR with #35. There's been a substantial amount of changes in the CSS since last December, and along with the changes in #35 makes this PR extremely difficult to merge.

However, I've marked you as a co-contributor in the relevant commits relating to dark mode and CSS variables in #35.

Apologies for not being able to mark this as merged :(

@syeopite syeopite closed this Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark theme support?
2 participants