-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major enhancement to the docker setup and the config file #37
Conversation
Should this line be removed then? Line 9 in 9bf96c4
I mostly just included it there due to this line in the documentation
|
@syeopite From what I understand it's only if you want to pass the IP to the application (in this case Priviblur)... which seem highly useless in this case. So I guess I can rewrite this part of the documentation to explain it like that? |
Can you just remove that entire section? I think I'll go just go ahead and remove those options entirely within the codebase since Priviblur does not need to know the users IP at all. |
@syeopite Sure |
@syeopite done |
Supersede the changes made in #36
Changes based on https://github.com/PussTheCat-org/docker-priviblur-quay
TL;DR:
Long version:
config file has been massively enhanced with documentation and now works OOTB with docker (host is now set to "0.0.0.0" by default since it's the standard) - comments "levels" have been standardized with one # for things that can be enabled and 2 for actual comments
Dockerfile has been redone from basically scratch and optimized in various ways (note: untested with the
COPY
since I clone the whole repo for my image, but you wanted it this way here, so I kept it this way)Add some documentation to the compose file (Note the "Taken from" line about redis as been replaced by "Partially taken from" since parts of it was my work, remove
version: "3"
(deprecated since more than a year)Note:
In the config file there's:
Looking at the sanic documentation "must be set" is just plain wrong.
"In order to use the Forwarded header, you should set app.config.FORWARDED_SECRET to a value known to the trusted proxy server. The secret is used to securely identify a specific proxy server."
So this is basically useless?
Might only be useful if you want priviblur to know the real IP of the user... which is basically useless?
"Setting PROXIES_COUNT tells Sanic how deep to look to get an actual IP address for the client."
So it's only useful if you reverse proxy more than once... so useless for most people?