Update npf-renderer to 0.12.0 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In server-side rendering, as posts are rendered one by one sequentially the results for polls must also be fetched sequentially. This results in a lengthy load time as Priviblur has to send dozens of requests one-by-one before the page can be returned. By populating the polls client side, this lengthy fetch process can be avoided entirely. For JS-disabled users, a fetch_polls URL parameter is provided as a fallback to allow for server-side fetching of poll results. However, due to the aforementioned reasons above, this is only available on individual posts.
Prior to this commit, it was naively assumed that a poll can only appear once on a page and as such each poll choice was assigned an HTML id of their given answer ID. However, due to the presence of reblogs, polls can in fact appear more than once on a single page and as such the logic in the poll filling JS fails due to the presence of duplicate IDs.
Trail polls should be fetched with the current post's blog name and ID
Fixes issue where polls would cover up the dropdown menus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npf-renderer's next release is set to add a bunch of new features such as support for videos (finally) and a new photoset layout system.
Some changes however are needed on Priviblur's side.
Closes #16