Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve logging #136

Merged
merged 23 commits into from
Mar 20, 2023
Merged

feat: improve logging #136

merged 23 commits into from
Mar 20, 2023

Conversation

mpetrun5
Copy link
Collaborator

@mpetrun5 mpetrun5 commented Mar 20, 2023 •
edited
Loading

  • Add contexts to evm and substrate handlers with domain ID and network name
  • Bump chainbridge-core to imrove EVm listner logging
  • add log that relayer not in MPC subset
  • add SYG_DOM log

Description

Related Issue Or Context

Closes: #124

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

MakMuftic
MakMuftic requested changes Mar 20, 2023
View reviewed changes
app/app.go Show resolved Hide resolved
chains/evm/chain.go Show resolved Hide resolved
@mpetrun5 mpetrun5 changed the title Mpetrun5/improve logging feat: improve logging Mar 20, 2023
@mpetrun5 mpetrun5 marked this pull request as ready for review March 20, 2023 14:03
@github-actions
Copy link
Contributor

Go Test coverage is 66.9 %\ ✨ ✨ ✨

@MakMuftic MakMuftic self-requested a review March 20, 2023 14:27
@github-actions
Copy link
Contributor

Go Test coverage is 66.9 %\ ✨ ✨ ✨

@github-actions
Copy link
Contributor

Go Test coverage is 66.9 %\ ✨ ✨ ✨

@P1sar P1sar merged commit 0958ec7 into main Mar 20, 2023
@P1sar P1sar deleted the mpetrun5/improve-logging branch March 20, 2023 16:28
@MakMuftic MakMuftic mentioned this pull request Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakMuftic MakMuftic MakMuftic approved these changes

@P1sar P1sar P1sar approved these changes

@waymobetta waymobetta Awaiting requested review from waymobetta

@tcar121293 tcar121293 Awaiting requested review from tcar121293 tcar121293 is a code owner

@nmlinaric nmlinaric Awaiting requested review from nmlinaric nmlinaric is a code owner

@freddyli7 freddyli7 Awaiting requested review from freddyli7 freddyli7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve verbosity of the logs
4 participants
@mpetrun5 @P1sar @MakMuftic @tcar121293