Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase max gas price allowed by default #133

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

mpetrun5
Copy link
Collaborator

@mpetrun5 mpetrun5 commented Mar 15, 2023

Set max gas price by default to be 500gwei. It won't be that much as it uses estimate gas price but that is the maximum.
If we want to change on mainnet it is easy to set it in the config.
All the other configurations seem reasonable.

Before it was 20 gwei and tx wouldn't appear on mumbai and goerli when the networks were congested.

Description

Related Issue Or Context

Closes: #132

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions
Copy link
Contributor

Go Test coverage is 67.1 %\ ✨ ✨ ✨

@github-actions
Copy link
Contributor

Go Test coverage is 67.0 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 merged commit a8fad65 into main Mar 16, 2023
@mpetrun5 mpetrun5 deleted the fix/sane-config-defaults branch March 16, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update EVM defaults to something sane
3 participants