[go] Update build instructions for golangci-lint #13121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #10825. Try to match more closely the build process followed upstream: - Force module build mode, which builds the latest stable release (not master), and takes care of module replacements. - Disable cgo. - The -trimpath argument to go get requires go >= 1.13, which is also needed because go <= 1.12 has a bug that causes problems with golangci-lint², as explained in the golangci-lint installation instructions². Note that the only thing that is missing to exactly match the upstream build process is the addition of some -X variables, which only affect the data reported by golangci-lint version. ¹: golang/go#29612 ²: https://github.com/golangci/golangci-lint#install Thanks to @dbriemann and @seriousben for reporting and clarifying this issue!
|
Thank you for contributing to Spacemacs. It's safe to delete your branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10825.
Try to match more closely the build process followed upstream:
Force module build mode, which builds the latest stable release (not master),
and takes care of module replacements.
Disable cgo.
The -trimpath argument to go get requires go >= 1.13, which is also needed
because go <= 1.12 has a bug that causes problems with golangci-lint², as
explained in the golangci-lint installation instructions².
Note that the only thing that is missing to exactly match the upstream build
process is the addition of some -X variables, which only affect the data
reported by golangci-lint version.
¹: golang/go#29612
²: https://github.com/golangci/golangci-lint#install
Thanks to @dbriemann and @seriousben for reporting and clarifying this issue!