-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using worf is so much better #1417
Conversation
I will put a break on this and take time to think about org and spacemacs, I want it a top notch integration. |
After being frustrated by |
I think this should be a layer of its own instead of being merged directly into the org layer, that way you can choose either the org bindings as they are now or the worf bindings which take over a lot more stuff. An added benefit is that this could get merged pretty quickly since it is totally optional instead of screwing everyone's bindings which depend on org mode. |
I agree with making this an additional layer for all the reasons you've said, and that the layer can deal specifically with compatibility issues between the packages. |
What do you think about having a |
fc49645
to
a40b242
Compare
Ok guys, I added the variable anyway :P @geo7 this way you can "try" evil-org as well :P. Also I added the |
I like this -- I want this |
👍 |
@TheBB we got approval of the PR police :P this shold be tagged.... |
I too want this 👍 |
To worf org not to worf. That is the question |
contrib/org/packages.el
Outdated
@@ -22,6 +22,17 @@ | |||
toc-org | |||
)) | |||
|
|||
(when org-mapping-style | |||
(push org-mapping-style org-packages)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit too magical maybe? I would rather worf
and evil-org
are both in org-packages
. You can use :if
in use-package
to pick which one to install, or just make the defuns conditional on the value of org-mapping-style
. That way both packages still show up in SPC f e h
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach much better thanks for the feedback :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#done :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!
On 08/26/2015 04:12 PM, Diego Berrocal wrote:
In contrib/org/packages.el
#1417 (comment):@@ -22,6 +22,17 @@
toc-org
))+(when org-mapping-style
- (push org-mapping-style org-packages))
#done :)
—
Reply to this email directly or view it on GitHub
https://github.com/syl20bnr/spacemacs/pull/1417/files#r38028998.
Can be 'worg, 'evil-org or nil
a40b242
to
19822fd
Compare
@syl20bnr now that we have evil-org i think this basically isn't very important? |
@CestDiego worf is similar, but different. It's more emacs-style, since it is a different way of doing orgmode speedkeys. You do worf things from inside insert state, but while on heading stars. Evil-org is very incomplete from what i've seen, compared to worf. |
Any update on this? |
Thanks for this ancient PR. I'll close it now because it has served its purpose. #9041 |
worf-mode gives more vi-like
key bindings for org-mode :D evil-org on the other hand shadows some
long stablished vim keybindings :) I feel you should try it. there is
not really a conf for it so maybe just try it?
THIS DELETES EVIL-ORG