Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Config Improvements #20

Merged
merged 5 commits into from
Oct 20, 2014
Merged

Conversation

trishume
Copy link
Contributor

Some minor improvements to configuration of default packages. I also have a contrib layer coming soon, but it isn't ready yet.

Includes:

  • Don't pair single quotes in lisp
  • Detect ledger files ending with .ldg (I ❤️ that spacemacs comes with ledger-mode and fish-mode).
  • Add a config variable for disabling packages. (added so I could disable jedi, which was broken for me.)
  • Remove broken neotree toggle modification (It errored out on activation for me).
  • Ignore the python environment created by jedi on install

@syl20bnr
Copy link
Owner

@trishume Love the disabled packages list, it was on the todo list for the contribution system!
I wonder what's broken in your python env. for jedi, usually installing jedi and epc via pypi is enough, there is a big work to do for the spacemacs dependencies: a makefile with an install rule for each package with external deps would be ideal, it should work on Windows, OS X and Linux.
The neotree stuff is a commit mistake, it is a WIP.
👍

syl20bnr added a commit that referenced this pull request Oct 20, 2014
@syl20bnr syl20bnr merged commit aaf6fef into syl20bnr:master Oct 20, 2014
@trishume
Copy link
Contributor Author

I did the install process for jedi, I think the reason it didn't work is that python on OSX is a mess, at least mine is. There's a version of python that comes with OSX which everything tries to use, and then I also have a version of python that was installed by homebrew as a dependency of some other package. I think it might be installing in one python install, then trying to load it from the other one. So even though I ran the install it says it hasn't installed yet.

Anyway it might be a while before I contribute to anything else since I accidentally broke my emacs after upgrading to Yosemite. I uninstalled to try building with different flags but then it turns out that homebrew can't build properly without XCode 6.1, which isn't really out yet. Once XCode 6.1 is out on the app store I'll get back to work.

@syl20bnr
Copy link
Owner

@trishume I just upgraded to 10.10 yesterday and I had some emacs binaries to rename again:

  • in /usr/bin (OS X)
  • in opt/local/bin (macports)

Then install homebrew version as usual (after having upgraded XCode CLI tools in the App Store):

brew install emacs --with-x

It was OK. Only weird thing, the unicode lighters in the mode-line have now the same size as railwaycat version.
For the sake of completion, I use the X version to be able to use i3 as a window manager, OS X just suck as a window manager :-(

@syl20bnr
Copy link
Owner

@trishume I renamed spacemacs-config-disabled-packages to dotspacemacs-excluded-packages and added the corresponding documentation. Do not forget to update your .spacemacs file when you pull the upstream commits.

I hope you will be able to get a working Emacs again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants