Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change shortcut of bookmarks in *spacemacs* buffer #2677

Closed
wants to merge 1 commit into from

Conversation

caikechao
Copy link
Contributor

In spacemacs buffer, the quick help in [?] shows that m jumps to
the menu. However, if one customizes the startup lists by setting
dotspacemacs-startup-lists '(recents bookmarks projects), the
shortcut m of jumping to the menu would be shadowed and m jumps to
Bookmarks.

With the help of @travisbhartwell and @TheBB, I changed the shortcut of
jumping to the Bookmarks to a to avoid this shortcut conflict.

@travisbhartwell
Copy link
Contributor

👍 Looks good to me!

@caikechao
Copy link
Contributor Author

@travisbhartwell 😄 Thanks again for your help!

@joehillen
Copy link
Contributor

👍

@nixmaniack
Copy link
Contributor

I hit this today! Seems simple enough change to get in develop @TheBB.

@caikechao
Copy link
Contributor Author

Sorry, I just run git rebase develop on my forked repo ... Did I mess up the pull request?

@StreakyCobra
Copy link
Contributor

A little bit 😂 I suppose you did the rebase against master not develop.

@caikechao
Copy link
Contributor Author

Oh... 😱 What can I do to make it right?

@StreakyCobra
Copy link
Contributor

You can try this:

git checkout bookmark-shortcut
git reset --hard  5797abe
git rebase develop

And if everything looks right you can the force the push:

git push -f

@caikechao
Copy link
Contributor Author

@StreakyCobra Thanks for your help! I am still learning git...

In *spacemacs* buffer, the quick help in `[?]` shows that `m` jumps to
the menu. However, if one customizes the startup lists by setting
`dotspacemacs-startup-lists '(recents bookmarks projects)`, the
shortcut `m` of jumping to the menu would be shadowed and `m` jumps to
Bookmarks.

With the help of @travisbhartwell and @TheBB, I changed the shortcut of
jumping to the Bookmarks to `a` to avoid this shortcut conflict.
@StreakyCobra
Copy link
Contributor

Thank you 👍 I updated the commit message to remove the @ in front of nicknames to avoid mentions.
Cherry-picked into develop branch, you can safely delete your branch.

@caikechao caikechao deleted the bookmark-shortcut branch January 4, 2016 01:47
@caikechao caikechao restored the bookmark-shortcut branch January 7, 2016 06:08
@caikechao caikechao deleted the bookmark-shortcut branch March 10, 2016 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants