Add jsfmt package to javascript lang layer. #3525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geksilla
force-pushed
the
feature/javascript-jsfmt
branch
from
4cbda17
to
20ba469
Compare
|
@TheBB, @StreakyCobra, can you check this one when you'll have an opportunity? Thanks! |
geksilla
force-pushed
the
feature/javascript-jsfmt
branch
from
20ba469
to
2423bf7
Compare
geksilla
force-pushed
the
feature/javascript-jsfmt
branch
from
2423bf7
to
fc113c8
Compare
|
👍 |
1 similar comment
|
👍 |
geksilla
force-pushed
the
feature/javascript-jsfmt
branch
from
fc113c8
to
66ad3d5
Compare
|
Is there something I could do to help this get merged? Was it just the README conflict that stopped it? |
Provide option to activate jsfmt by default. Added keybindng to toggle jsfmt mode. Added installation and configuration example to Readme.
geksilla
force-pushed
the
feature/javascript-jsfmt
branch
from
66ad3d5
to
dcc62b7
Compare
|
Resolved merge conflicts. |
|
@syl20bnr Any updates on this? |
|
You know how things work around here..be patient.
…On 06/23/2018 07:39 AM, Compro Prasad wrote:
@syl20bnr <https://github.com/syl20bnr> Any updates on this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3525 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABaMBtC2TFdijYNKW42TmLRNUXGfmsPks5t_ijogaJpZM4GUaOj>.
|
bjartur
reviewed
Oct 4, 2019
|
@geksilla Rebase needed :) |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this PR is still need merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added plugin jsfmt.el to javascript layer and installation instruction.