git: Add new evil-magit bindings

[justbur]

Also turn off evilification for magit conditional on the evil-magit
package being used.

[justbur]

@a13ph @mbertheau

[syl20bnr]

Nice work 👍
Can we wait for this being available in MELPA or is there anything holding it from being hosted there ?

[justbur]

I wanted to do it officially through the magit repo to get others to look
at it and critique it. I could obviously make my own package though. What
do you think?
On Wed, Oct 28, 2015 at 10:05 AM Sylvain Benner notifications@github.com
wrote:

Nice work [image: 👍]
Can we wait for this being available MELPA or is there anything holding it
from being hosted there ?

—
Reply to this email directly or view it on GitHub
#3578 (comment).

[syl20bnr]

I wanted to do it officially through the magit repo to get others to look at it and critique it.

Good point. As soon as it is merged (by me or @TheBB), we can open an issue to discuss about the proposal and reference the PR link in the evil-magit repo.

[nixmaniack]

@justbur Amazing experience! Pretty evil! 😈 👍 Been using it for some time, feels home.

[CestDiego]

I can't wait for this to be merged. :)

[TheBB]

Is this magit 2.3 certified ® © ™?

[justbur]

@TheBB It looks to me like we were getting the 2.3 commits the whole time. In other words, it's only a significant upgrade for the stable users

[syl20bnr]

Thank you 👍

[justbur]

Thank you @syl20bnr !

[CestDiego]

#itsHappening! :)

[PierreR]

For the record, the latest commit t 150e38e in develop has increased the loading startup time significantly. At least for me ;-)

[justbur]

@PierreR It's quelpa downloading the package. It should only happen once. As soon as this new package is on melpa we'll switch back. For the record, this is not the only quelpa package in use

[justbur]

@PierreR hm. It looks like quelpa is not handling the dependency correctly

[justbur]

@PierreR After spacemacs loads do M-x package-install RET magit RET as a workaround

[justbur]

then restart

[PierreR]

After spacemacs loads do M-x package-install RET magit RET as a workaround

@justbur well I have a lot of magit-* package when I do that but no magit alone

[CestDiego]

I lost the ability to go up/down one line :( to have precise selection staging. is this expected?

[justbur]

@PierreR ok, then it seems it is installed but can't be found. Go into .emacs.d/elpa and look for a magit-[date] folder and a evil-magit-[date] folder. Delete both and restart. You might have a bad download of magit

[justbur]

@CestDiego magit uses n and p to navigate sections and C-n and C-p to navigate by line. Just swap j for n and k for p in those

[CestDiego]

n makes a search forward D: p works ok though

[PierreR]

@justbur Thanks. Your last tip fixes it ;-)

[justbur]

@CestDiego https://github.com/justbur/spacemacs/blob/evil-magit-doc/layers/%2Bsource-control/git/README.org#magit (not merged yet)

[justbur]

@PierreR 👍 I get an abnormal number of corrupted downloads from melpa. I have no idea why, but usually redownloading the package works

[CestDiego]

I thought updating would make this work.

[justbur]

I thought updating would make this work.

Is that directed at me? What do you mean?

[justbur]

@CestDiego anyway use #3592 for comments on the bindings

[CestDiego]

@justbur I thought that updating spacemacs (given that this PR was merged) would make n and p work as evil-magit makes it. And would not make n do next-search

[justbur]

@CestDiego please read the documentation I linked to which is merged by the way. j and k play the role of n and p. also see the pull request at magit/evil-magit

[CestDiego]

I misunderstood your comment and was confused by the link. Now I get it :) C-j and C-k are what moves one in lines :) amazing :) thanks

[CestDiego]

@justbur @syl20bnr I want to raise a big concern regading j k for chunks and C-j C-k for lines.

I want to explain why this is not a good translation directly from the Emacs keybindings:

In Emacs you move up and down lines with C-p and C-n, and that is unchanged in magit, additionally, in magit you use p and n to move up and down chunks... So basically the way you move lines is not changed.

In Evil, you move up and down with k and j, but in evil-magit you move up and down in lines with C-k and C-j which is very confusing , and more when you try to select lines and have to switch your mind from using j|k to move between lines to C-j|C-k ... I hope you guys can see my point and evaluate it while you also use the region staging features.

[justbur]

@CestDiego update your packages. this was already changed

[CestDiego]

@justbur I just updated, the behaviour is changed :) but when I try to select regions, I can't use j nor k only C-n and C-p is this expected?

[justbur]

@CestDiego no not expected. What's the context? What buffer?
On Fri, Nov 6, 2015 at 3:52 PM Diego Berrocal notifications@github.com
wrote:

@justbur https://github.com/justbur I just updated, the behaviour is
changed :) but when I try to select regions, I can't use j nor k only C-n
and C-p is this expected?

—
Reply to this email directly or view it on GitHub
#3578 (comment).

[CestDiego]

@justbur the magit-status buffer....just trying to select regions to stage.

[justbur]

@CestDiego after hitting v or V?
On Fri, Nov 6, 2015 at 4:11 PM Diego Berrocal notifications@github.com
wrote:

@justbur https://github.com/justbur the magit-status buffer....just
trying to select regions to stage.

—
Reply to this email directly or view it on GitHub
#3578 (comment).

[CestDiego]

any of those will say: Mark Activated and after pressing j it'll exit the mark

[justbur]

What does exit the mark mean?

[CestDiego]

woops, I meant exit the selection..and the marks dissappear.

[justbur]

I own the repo now. Just open an issue and I'll look into it.
On Fri, Nov 6, 2015 at 4:20 PM Diego Berrocal notifications@github.com
wrote:

woops, I meant exit the selection..and the marks dissappear.

—
Reply to this email directly or view it on GitHub
#3578 (comment).

[nixmaniack]

I can use jk when selecting regions to stage after hitting v/V. Does the evil-state matter? I'm using hybrid.

[justbur]

@nixmaniack right now no it shouldn't make any difference what editing style you use.