Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mask # in the org mode #4811

Closed
wants to merge 2 commits into from
Closed

Conversation

JAremko
Copy link
Collaborator

@JAremko JAremko commented Jan 26, 2016

With Emacs you can have your 🍰 and eat it too 😄
It fixes #4399 ?

Disclaimer

no idea

Not tested and probably misunderstood early morning pr

@nixmaniack
Copy link
Contributor

Looks like it doesn't allow you to open with org-open-at-point (, l or C-c C-o) from ToC. Custom id needed.

@JAremko
Copy link
Collaborator Author

JAremko commented Jan 26, 2016

@nixmaniack At least it looks well. Might be with some extra magic it will work?

@robbyoconnor
Copy link
Contributor

On the internet, nobody knows you're a dog.

@JAremko
Copy link
Collaborator Author

JAremko commented Jan 26, 2016

I think the most of new users rely on the github docs, it is important that the docs look well polished and definitely not have broken links.

org-open-at-point can be fixed with a some kind of wrapper function and might be a special mode for the Spamecas doc headers. For example, add notation to the headers and if cursor is in the denoted block - enable special mode that fixes org-open-at-point

@JAremko
Copy link
Collaborator Author

JAremko commented Jan 26, 2016

@robbyoconnor Unless you post your selfie 🐶

@TheBB
Copy link
Collaborator

TheBB commented Jan 26, 2016

But if we want to revert to github links we should do it with toc-org, as we used to, and not manually like this.

There are three links that should work:

  • Inside Emacs (works right now)
  • Github (does not work right now)
  • Exported (works right now)

This PR breaks two of them for the benefit of github. toc-org at least would keep it working in Emacs.

@nixmaniack
Copy link
Contributor

Do we update docs on website with every change in doc? If not I would suggest reverting back to toc-org as it keeps Emacs and github working and for website generate docs in another branch with every release.

@JAremko
Copy link
Collaborator Author

JAremko commented Jan 26, 2016

@TheBB This updates works properly. At the first glance.

@JAremko
Copy link
Collaborator Author

JAremko commented Jan 26, 2016

@nixmaniack Or use sed to append #. Then simply run Emacs in the batch mode over the *.org files to fix the links with toc-org.

@JAremko
Copy link
Collaborator Author

JAremko commented Jan 28, 2016

I think I'll close it and we all gonna pretend that it never happened. Okay? /woof

@JAremko JAremko closed this Jan 28, 2016
@JAremko JAremko deleted the issue-4399-pr branch April 16, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants