Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support '--env-file flag with OCI launcher. #1030

Closed
Tracked by #598
dtrudg opened this issue Oct 10, 2022 · 0 comments · Fixed by #1170
Closed
Tracked by #598

Support '--env-file flag with OCI launcher. #1030

dtrudg opened this issue Oct 10, 2022 · 0 comments · Fixed by #1170
Labels
enhancement New feature or request roadmap Features / changes that are scheduled to be implemented

Comments

@dtrudg
Copy link
Member

dtrudg commented Oct 10, 2022

Set environment variable values from a file provided via the CLI --env-file option in the config.json for the container launched via the OCI launcher.

Note any differences with variable interpretation, versus the singularity runtime, and add warning messages where an env var might be subject to these differences.

@dtrudg dtrudg added this to the SingularityCE 3.11 milestone Oct 10, 2022
@dtrudg dtrudg added enhancement New feature or request roadmap Features / changes that are scheduled to be implemented labels Oct 10, 2022
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 6, 2022
Allow --env-file to be used to provide environment variables in a
file, when running a container in --oci mode.

We use the same approach as the native runtime for compatibility. The
env file is evaluated in the embedded shell interpreter, but starting
with an empty environment. This handles quoting, comments etc. for us,
and keeps maximum compatibility with the existing handling.

Fixes sylabs#1030
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 7, 2022
Allow --env-file to be used to provide environment variables in a
file, when running a container in --oci mode.

We use the same approach as the native runtime for compatibility. The
env file is evaluated in the embedded shell interpreter, but starting
with an empty environment. This handles quoting, comments etc. for us,
and keeps maximum compatibility with the existing handling.

Fixes sylabs#1030
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jan 26, 2023
Allow --env-file to be used to provide environment variables in a
file, when running a container in --oci mode.

We use the same approach as the native runtime for compatibility. The
env file is evaluated in the embedded shell interpreter, but starting
with an empty environment. This handles quoting, comments etc. for us,
and keeps maximum compatibility with the existing handling.

Fixes sylabs/singularity#1030

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 9, 2023
Allow --env-file to be used to provide environment variables in a
file, when running a container in --oci mode.

We use the same approach as the native runtime for compatibility. The
env file is evaluated in the embedded shell interpreter, but starting
with an empty environment. This handles quoting, comments etc. for us,
and keeps maximum compatibility with the existing handling.

Fixes sylabs/singularity#1030

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 11, 2023
Allow --env-file to be used to provide environment variables in a
file, when running a container in --oci mode.

We use the same approach as the native runtime for compatibility. The
env file is evaluated in the embedded shell interpreter, but starting
with an empty environment. This handles quoting, comments etc. for us,
and keeps maximum compatibility with the existing handling.

Fixes sylabs/singularity#1030

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 11, 2023
Allow --env-file to be used to provide environment variables in a
file, when running a container in --oci mode.

We use the same approach as the native runtime for compatibility. The
env file is evaluated in the embedded shell interpreter, but starting
with an empty environment. This handles quoting, comments etc. for us,
and keeps maximum compatibility with the existing handling.

Fixes sylabs/singularity#1030

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 23, 2023
Allow --env-file to be used to provide environment variables in a
file, when running a container in --oci mode.

We use the same approach as the native runtime for compatibility. The
env file is evaluated in the embedded shell interpreter, but starting
with an empty environment. This handles quoting, comments etc. for us,
and keeps maximum compatibility with the existing handling.

Fixes sylabs/singularity#1030

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Mar 31, 2023
Allow --env-file to be used to provide environment variables in a
file, when running a container in --oci mode.

We use the same approach as the native runtime for compatibility. The
env file is evaluated in the embedded shell interpreter, but starting
with an empty environment. This handles quoting, comments etc. for us,
and keeps maximum compatibility with the existing handling.

Fixes sylabs/singularity#1030

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue May 24, 2023
Allow --env-file to be used to provide environment variables in a
file, when running a container in --oci mode.

We use the same approach as the native runtime for compatibility. The
env file is evaluated in the embedded shell interpreter, but starting
with an empty environment. This handles quoting, comments etc. for us,
and keeps maximum compatibility with the existing handling.

Fixes sylabs/singularity#1030

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue May 24, 2023
Allow --env-file to be used to provide environment variables in a
file, when running a container in --oci mode.

We use the same approach as the native runtime for compatibility. The
env file is evaluated in the embedded shell interpreter, but starting
with an empty environment. This handles quoting, comments etc. for us,
and keeps maximum compatibility with the existing handling.

Fixes sylabs/singularity#1030

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 14, 2023
Allow --env-file to be used to provide environment variables in a
file, when running a container in --oci mode.

We use the same approach as the native runtime for compatibility. The
env file is evaluated in the embedded shell interpreter, but starting
with an empty environment. This handles quoting, comments etc. for us,
and keeps maximum compatibility with the existing handling.

Fixes sylabs/singularity#1030

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 14, 2023
Allow --env-file to be used to provide environment variables in a
file, when running a container in --oci mode.

We use the same approach as the native runtime for compatibility. The
env file is evaluated in the embedded shell interpreter, but starting
with an empty environment. This handles quoting, comments etc. for us,
and keeps maximum compatibility with the existing handling.

Fixes sylabs/singularity#1030

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 16, 2023
Allow --env-file to be used to provide environment variables in a
file, when running a container in --oci mode.

We use the same approach as the native runtime for compatibility. The
env file is evaluated in the embedded shell interpreter, but starting
with an empty environment. This handles quoting, comments etc. for us,
and keeps maximum compatibility with the existing handling.

Fixes sylabs/singularity#1030

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 4, 2023
Allow --env-file to be used to provide environment variables in a
file, when running a container in --oci mode.

We use the same approach as the native runtime for compatibility. The
env file is evaluated in the embedded shell interpreter, but starting
with an empty environment. This handles quoting, comments etc. for us,
and keeps maximum compatibility with the existing handling.

Fixes sylabs/singularity#1030

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 11, 2023
Allow --env-file to be used to provide environment variables in a
file, when running a container in --oci mode.

We use the same approach as the native runtime for compatibility. The
env file is evaluated in the embedded shell interpreter, but starting
with an empty environment. This handles quoting, comments etc. for us,
and keeps maximum compatibility with the existing handling.

Fixes sylabs/singularity#1030

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 21, 2023
Allow --env-file to be used to provide environment variables in a
file, when running a container in --oci mode.

We use the same approach as the native runtime for compatibility. The
env file is evaluated in the embedded shell interpreter, but starting
with an empty environment. This handles quoting, comments etc. for us,
and keeps maximum compatibility with the existing handling.

Fixes sylabs/singularity#1030

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 24, 2023
Allow --env-file to be used to provide environment variables in a
file, when running a container in --oci mode.

We use the same approach as the native runtime for compatibility. The
env file is evaluated in the embedded shell interpreter, but starting
with an empty environment. This handles quoting, comments etc. for us,
and keeps maximum compatibility with the existing handling.

Fixes sylabs/singularity#1030

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request roadmap Features / changes that are scheduled to be implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant