Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support '--apply-cgroups' with OCI launcher. #1032

Closed
Tracked by #598
dtrudg opened this issue Oct 10, 2022 · 0 comments · Fixed by #1177
Closed
Tracked by #598

Support '--apply-cgroups' with OCI launcher. #1032

dtrudg opened this issue Oct 10, 2022 · 0 comments · Fixed by #1177
Labels
enhancement New feature or request roadmap Features / changes that are scheduled to be implemented
Milestone
SingularityCE 3.11

Comments

@dtrudg
Copy link
Member

dtrudg commented Oct 10, 2022 •
edited
Loading

Read a cgroups resource configuration file specified with the --apply-cgroups flag, and pass the resource limits into the config.json used by the OCI launcher to start its container, or setup the cgroup prior and pass it's path in config.json.

Ensure that:

  • Root with cgroups v1 works.
  • Root with cgroups v2 works.
  • Non-root with cgroups v2 works (with device limits etc. that cannot be set being dropped for the container launch).
@dtrudg dtrudg mentioned this issue Oct 10, 2022
Closed
17 tasks
@dtrudg dtrudg added this to the SingularityCE 3.11 milestone Oct 10, 2022
@dtrudg dtrudg added enhancement New feature or request roadmap Features / changes that are scheduled to be implemented labels Oct 10, 2022
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 7, 2022
@dtrudg
feat: oci: support cgroups requests in --oci mode
3b37ef2 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher creates a cgroup manager, moves itself inside, and then
calls the low-level OCI runtime passing the cgroup path in the
config.json.

Closes sylabs#1032
@dtrudg dtrudg mentioned this issue Dec 7, 2022
Merged
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 13, 2022
@dtrudg
feat: oci: support cgroups requests in --oci mode
b2d8c9c 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher creates a cgroup manager, moves itself inside, and then
calls the low-level OCI runtime passing the cgroup path in the
config.json.

Closes sylabs#1032
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 13, 2022
@dtrudg
feat: oci: support cgroups requests in --oci mode
34f1ada 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs#1032
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 13, 2022
@dtrudg
feat: oci: support cgroups requests in --oci mode
0fc156d 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs#1032
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 13, 2022
@dtrudg
feat: oci: support cgroups requests in --oci mode
13e1e55 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs#1032
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 13, 2022
@dtrudg
feat: oci: support cgroups requests in --oci mode
1540daa 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs#1032
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 13, 2022
@dtrudg
feat: oci: support cgroups requests in --oci mode
a9c2e72 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs#1032
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 13, 2022
@dtrudg
feat: oci: support cgroups requests in --oci mode
2e617a5 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs#1032
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 13, 2022
@dtrudg
feat: oci: support cgroups requests in --oci mode
d0c2fa0 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs#1032
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 13, 2022
@dtrudg
feat: oci: support cgroups requests in --oci mode
449a015 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs#1032
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 13, 2022
@dtrudg
feat: oci: support cgroups requests in --oci mode
88e5d04 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs#1032
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 13, 2022
@dtrudg
feat: oci: support cgroups requests in --oci mode
62b4275 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs#1032
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 22, 2022
@dtrudg
feat: oci: support cgroups requests in --oci mode
fed0229 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs#1032
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 23, 2023
@dtrudg @edytuk
feat: oci: support cgroups requests in --oci mode
a10abb6 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs/singularity#1032

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 23, 2023
@dtrudg @edytuk
feat: oci: support cgroups requests in --oci mode
af2ec21 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs/singularity#1032

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 23, 2023
@dtrudg @edytuk
feat: oci: support cgroups requests in --oci mode
3f82572 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs/singularity#1032

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Mar 31, 2023
@dtrudg @edytuk
feat: oci: support cgroups requests in --oci mode
2f02600 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs/singularity#1032

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue May 24, 2023
@dtrudg @edytuk
feat: oci: support cgroups requests in --oci mode
1b94c19 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs/singularity#1032

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue May 24, 2023
@dtrudg @edytuk
feat: oci: support cgroups requests in --oci mode
1593aa4 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs/singularity#1032

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 14, 2023
@dtrudg @edytuk
feat: oci: support cgroups requests in --oci mode
71e45fb 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs/singularity#1032

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 14, 2023
@dtrudg @edytuk
feat: oci: support cgroups requests in --oci mode
d09a239 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs/singularity#1032

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 14, 2023
@dtrudg @edytuk
feat: oci: support cgroups requests in --oci mode
ea4fa72 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs/singularity#1032

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 16, 2023
@dtrudg @edytuk
feat: oci: support cgroups requests in --oci mode
7a417f3 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs/singularity#1032

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 4, 2023
@dtrudg @edytuk
feat: oci: support cgroups requests in --oci mode
fb2ec7d 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs/singularity#1032

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 11, 2023
@dtrudg @edytuk
feat: oci: support cgroups requests in --oci mode
428fa36 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs/singularity#1032

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 21, 2023
@dtrudg @edytuk
feat: oci: support cgroups requests in --oci mode
9cc33e3 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs/singularity#1032

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 24, 2023
@dtrudg @edytuk
feat: oci: support cgroups requests in --oci mode
61ca14a 
Honor the --apply-cgroups and individual cgroups resources flags when
running in OCI mode.

The launcher instructs runc/crun to create a named cgroup with
specified LinuxResources in the config.json. runc/crun must be called
with the `--systemd-cgroup` flag when using systemd as cgroup manager.

Closes sylabs/singularity#1032

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request roadmap Features / changes that are scheduled to be implemented
Projects
None yet
Milestone
SingularityCE 3.11
Development

Successfully merging a pull request may close this issue.

feat: oci: support cgroups requests in --oci mode dtrudg/singularity
1 participant
@dtrudg