Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support '--rocm' with OCI launcher. #1034

Closed
Tracked by #598
dtrudg opened this issue Oct 10, 2022 · 0 comments · Fixed by #1181
Closed
Tracked by #598

Support '--rocm' with OCI launcher. #1034

dtrudg opened this issue Oct 10, 2022 · 0 comments · Fixed by #1181
Labels
enhancement New feature or request roadmap Features / changes that are scheduled to be implemented
Milestone
SingularityCE 3.11

Comments

@dtrudg
Copy link
Member

dtrudg commented Oct 10, 2022 •
edited
Loading

Implement the legacy --rocm GPU library binding for AMD cards in the OCI launcher flow.

  • Identify ROCm libraries and binaries to bind into the container, using the existing code that relies on rocmliblist.conf.
  • Bind these into the container at /.singularity.d/libs or another appropriate specific path.
  • Add the appropriate LD_CONFIG and PATH environment so that they are picked up in the container.
@dtrudg dtrudg mentioned this issue Oct 10, 2022
Closed
17 tasks
@dtrudg dtrudg added this to the SingularityCE 3.11 milestone Oct 10, 2022
@dtrudg dtrudg added enhancement New feature or request roadmap Features / changes that are scheduled to be implemented labels Oct 10, 2022
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 8, 2022
@dtrudg
feat: oci: Support --rocm with --oci mode
b573ed4 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs#1034
@dtrudg dtrudg mentioned this issue Dec 8, 2022
Merged
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 9, 2022
@dtrudg
feat: oci: Support --rocm with --oci mode
6ef1d36 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs#1034
dtrudg added a commit to dtrudg/singularity that referenced this issue Dec 9, 2022
@dtrudg
feat: oci: Support --rocm with --oci mode
8ca1332 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs#1034
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 2, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
d8a7d79 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 2, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
89d7397 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 6, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
6cd7f82 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
@edytuk edytuk mentioned this issue Feb 7, 2023
Merged
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 9, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
92b6fc8 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 11, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
7294cae 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 11, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
750e31f 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 23, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
6338f69 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Mar 31, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
c42d87e 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue May 24, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
174d926 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue May 24, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
c54f520 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 14, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
89be97f 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 14, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
f30470a 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 14, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
5787ba1 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 16, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
e579e4b 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 4, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
5f601bf 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 11, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
b372b05 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 21, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
9c619ad 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 24, 2023
@dtrudg @edytuk
feat: oci: Support --rocm with --oci mode
78504a9 
Under --oci mode, allow --rocm, which will bind ROCm devices,
libraries, and binaries into the container.

Fixes sylabs/singularity#1034

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request roadmap Features / changes that are scheduled to be implemented
Projects
None yet
Milestone
SingularityCE 3.11
Development

Successfully merging a pull request may close this issue.

rocm: fixups and --oci support dtrudg/singularity
1 participant
@dtrudg