Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port RPM spec improvements from Fedora review #1142

Closed
dtrudg opened this issue Nov 28, 2022 · 0 comments · Fixed by #1143
Closed

Port RPM spec improvements from Fedora review #1142

dtrudg opened this issue Nov 28, 2022 · 0 comments · Fixed by #1143
Assignees
@dtrudg
Milestone
SingularityCE 3.11

Comments

@dtrudg
Copy link
Member

dtrudg commented Nov 28, 2022

Type of issue

technical debt

Description of issue

The Fedora review at https://bugzilla.redhat.com/show_bug.cgi?id=2145834 has raised various improvements.

We can't take everything here, with respect to simplification, but we can bring across many of the changes. Still need to support SLES builds, ensure nothing uses rpm functionality not present in EL, etc.
@dtrudg dtrudg added this to the SingularityCE 3.11 milestone Nov 28, 2022
@dtrudg dtrudg self-assigned this Nov 28, 2022
dtrudg added a commit to dtrudg/singularity that referenced this issue Nov 28, 2022
@dtrudg
pkg: Update / tidy rpm spec file
9c3d25e 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs#1142
Fixes sylabs#1141
@dtrudg dtrudg mentioned this issue Nov 28, 2022
Merged
dtrudg added a commit to dtrudg/singularity that referenced this issue Nov 28, 2022
@dtrudg
pkg: Update / tidy rpm spec file
d422324 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs#1142
Fixes sylabs#1141
edytuk pushed a commit to vzokay/apptainer that referenced this issue Dec 5, 2022
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
ea8446d 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Dec 5, 2022
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
e9afc84 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Dec 5, 2022
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
f69127f 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Dec 6, 2022
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
f596920 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Dec 6, 2022
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
90955fc 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Dec 6, 2022
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
232cc44 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Dec 6, 2022
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
815e349 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Dec 6, 2022
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
7f02793 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Dec 6, 2022
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
28ef545 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Dec 6, 2022
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
3541001 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Dec 6, 2022
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
23d6980 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 9, 2023
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
d3424f4 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 23, 2023
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
646eef0 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Mar 31, 2023
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
1d1bca7 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue May 24, 2023
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
7dd62fd 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue May 24, 2023
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
ad578fe 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 14, 2023
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
5e1507a 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 14, 2023
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
0e7f381 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 16, 2023
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
3d2c3d0 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 4, 2023
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
4563242 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 11, 2023
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
4fb7e81 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 21, 2023
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
4a020d9 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 24, 2023
@dtrudg @edytuk
pkg: Update / tidy rpm spec file
a56974a 
Tidy up the rpm spec file.

* Remove the manual handling of build root, GOPATH etc. Not needed as
  we are using go modules now.
* Remove redundant explicit deps.
* Fix crun -> runc dep for EL7.
* Use rpm make_xxx macros instead of direct make calls.
* Ensure all directories created are owned by package.

Fixes sylabs/singularity#1142
Fixes sylabs/singularity#1141

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtrudg dtrudg

Labels
None yet
Projects
None yet
Milestone
SingularityCE 3.11
Development

Successfully merging a pull request may close this issue.

pkg: Update / tidy rpm spec file dtrudg/singularity
1 participant
@dtrudg