Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--oci mode fails with no passwd file in container #1286

Closed
dtrudg opened this issue Feb 6, 2023 · 0 comments · Fixed by #1287
Closed

--oci mode fails with no passwd file in container #1286

dtrudg opened this issue Feb 6, 2023 · 0 comments · Fixed by #1287
Assignees
Labels
bug Something isn't working

Comments

@dtrudg
Copy link
Member

dtrudg commented Feb 6, 2023

Version of Singularity
3.11.0-rc.2

Describe the bug

$ singularity run --oci docker://hello-world
Getting image source signatures
Copying blob 2db29710123e done  
Copying config 811f3caa88 done  
Writing manifest to image destination
Storing signatures
2023/02/06 15:18:44  info unpack layer: sha256:2db29710123e3e53a794f2694094b9b4338aa9ee5c40b930cb8063a1be392c54
FATAL:   while creating passwd file: passwd file doesn't exist in container, not updating

This should be a WARNING, like non --oci mode...

$ singularity run docker://hello-world
INFO:    Converting OCI blobs to SIF format
INFO:    Starting build...
2023/02/06 15:19:40  info unpack layer: sha256:2db29710123e3e53a794f2694094b9b4338aa9ee5c40b930cb8063a1be392c54
INFO:    Creating SIF file...
WARNING: passwd file doesn't exist in container, not updating
WARNING: group file doesn't exist in container, not updating

Hello from Docker!
This message shows that your installation appears to be working correctly.

To generate this message, Docker took the following steps:
 1. The Docker client contacted the Docker daemon.
 2. The Docker daemon pulled the "hello-world" image from the Docker Hub.
    (amd64)
 3. The Docker daemon created a new container from that image which runs the
    executable that produces the output you are currently reading.
 4. The Docker daemon streamed that output to the Docker client, which sent it
    to your terminal.

To try something more ambitious, you can run an Ubuntu container with:
 $ docker run -it ubuntu bash

Share images, automate workflows, and more with a free Docker ID:
 https://hub.docker.com/

For more examples and ideas, visit:
 https://docs.docker.com/get-started/
@dtrudg dtrudg added the bug Something isn't working label Feb 6, 2023
@dtrudg dtrudg added this to the SingularityCE 3.11 milestone Feb 6, 2023
@dtrudg dtrudg self-assigned this Feb 6, 2023
dtrudg added a commit to dtrudg/singularity that referenced this issue Feb 6, 2023
In the --oci launcher, When a minimal container doesn't have an
`/etc/passwd` or `/etc/groups` file then don't fail with a fatal
error. Instead warn like the native runtime does.

Fixes sylabs#1286
dtrudg added a commit to dtrudg/singularity that referenced this issue Feb 6, 2023
In the --oci launcher, When a minimal container doesn't have an
`/etc/passwd` or `/etc/groups` file then don't fail with a fatal
error. Instead warn like the native runtime does.

Fixes sylabs#1286
dtrudg added a commit to dtrudg/singularity that referenced this issue Feb 6, 2023
In the --oci launcher, When a minimal container doesn't have an
`/etc/passwd` or `/etc/groups` file then don't fail with a fatal
error. Instead warn like the native runtime does.

Fixes sylabs#1286
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 20, 2023
In the --oci launcher, When a minimal container doesn't have an
`/etc/passwd` or `/etc/groups` file then don't fail with a fatal
error. Instead warn like the native runtime does.

Fixes sylabs/singularity#1286

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Feb 23, 2023
In the --oci launcher, When a minimal container doesn't have an
`/etc/passwd` or `/etc/groups` file then don't fail with a fatal
error. Instead warn like the native runtime does.

Fixes sylabs/singularity#1286

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Mar 31, 2023
In the --oci launcher, When a minimal container doesn't have an
`/etc/passwd` or `/etc/groups` file then don't fail with a fatal
error. Instead warn like the native runtime does.

Fixes sylabs/singularity#1286

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue May 24, 2023
In the --oci launcher, When a minimal container doesn't have an
`/etc/passwd` or `/etc/groups` file then don't fail with a fatal
error. Instead warn like the native runtime does.

Fixes sylabs/singularity#1286

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue May 24, 2023
In the --oci launcher, When a minimal container doesn't have an
`/etc/passwd` or `/etc/groups` file then don't fail with a fatal
error. Instead warn like the native runtime does.

Fixes sylabs/singularity#1286

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 14, 2023
In the --oci launcher, When a minimal container doesn't have an
`/etc/passwd` or `/etc/groups` file then don't fail with a fatal
error. Instead warn like the native runtime does.

Fixes sylabs/singularity#1286

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 14, 2023
In the --oci launcher, When a minimal container doesn't have an
`/etc/passwd` or `/etc/groups` file then don't fail with a fatal
error. Instead warn like the native runtime does.

Fixes sylabs/singularity#1286

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 14, 2023
In the --oci launcher, When a minimal container doesn't have an
`/etc/passwd` or `/etc/groups` file then don't fail with a fatal
error. Instead warn like the native runtime does.

Fixes sylabs/singularity#1286

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jun 16, 2023
In the --oci launcher, When a minimal container doesn't have an
`/etc/passwd` or `/etc/groups` file then don't fail with a fatal
error. Instead warn like the native runtime does.

Fixes sylabs/singularity#1286

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 4, 2023
In the --oci launcher, When a minimal container doesn't have an
`/etc/passwd` or `/etc/groups` file then don't fail with a fatal
error. Instead warn like the native runtime does.

Fixes sylabs/singularity#1286

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 11, 2023
In the --oci launcher, When a minimal container doesn't have an
`/etc/passwd` or `/etc/groups` file then don't fail with a fatal
error. Instead warn like the native runtime does.

Fixes sylabs/singularity#1286

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 21, 2023
In the --oci launcher, When a minimal container doesn't have an
`/etc/passwd` or `/etc/groups` file then don't fail with a fatal
error. Instead warn like the native runtime does.

Fixes sylabs/singularity#1286

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk pushed a commit to vzokay/apptainer that referenced this issue Jul 24, 2023
In the --oci launcher, When a minimal container doesn't have an
`/etc/passwd` or `/etc/groups` file then don't fail with a fatal
error. Instead warn like the native runtime does.

Fixes sylabs/singularity#1286

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant