Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Deprecated UUID Package #3

Closed
tri-adam opened this issue May 4, 2021 · 1 comment · Fixed by #112
Closed

Replace Deprecated UUID Package #3

tri-adam opened this issue May 4, 2021 · 1 comment · Fixed by #112
Assignees
@tri-adam
Labels
roadmap Features / changes that are scheduled to be implemented techdebt
Milestone
SingularityCE 3.9.0

Comments

@tri-adam
Copy link
Member

tri-adam commented May 4, 2021

The github.com/satori/go.uuid module used by this project does not appear to be actively maintained (ref).

We should consider switching to the github.com/gofrs/uuid package, or some other suitable alternative.
@dtrudg dtrudg added the techdebt label May 4, 2021
@tri-adam
Copy link
Member Author

tri-adam commented May 5, 2021

Added some thoughts to this on a related SIF issue (sylabs/sif#7 (comment)). Singularity is using the sif.CreateInfo type directly, including the ID field that would be affected by this change, so we should come up with a consistent approach.

This was referenced Jun 23, 2021
Merged
Merged
@dtrudg dtrudg added this to the SingularityCE 3.9.0 milestone Jul 2, 2021
@dtrudg dtrudg added the roadmap Features / changes that are scheduled to be implemented label Jul 2, 2021
@tri-adam tri-adam mentioned this issue Aug 31, 2021
Merged
@edytuk edytuk mentioned this issue Oct 26, 2021
Closed
@edytuk edytuk mentioned this issue Nov 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tri-adam tri-adam

Labels
roadmap Features / changes that are scheduled to be implemented techdebt
Projects
None yet
Milestone
SingularityCE 3.9.0
Development

Successfully merging a pull request may close this issue.

Upgrade to SIF v2 (master) tri-adam/singularity
2 participants
@dtrudg @tri-adam