Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable staticcheck Linter, replace golang.org/x/crypto/ssh/terminal, upgrade to SIF v2, merge 3.8.3 changelog / install.md changes to master, from sylabs 283, 296, 112, 305 #3

Closed
wants to merge 6 commits into from

Conversation

edytuk
Copy link
Owner

@edytuk edytuk commented Oct 25, 2021

This pulls in sylabs PRs

The original PR descriptions were:

Enable staticcheck linter, and address associated lint.

Replace the deprecated golang.org/x/crypto/ssh/terminal package with golang.org/x/term.

Replace github.com/sylabs/sif module with github.com/sylabs/sif/v2. Replace deprecated golang.org/x/crypto/openpgp package within forked golang.org/x/crypto module (github.com/sylabs/golang-x-crypto) with github.com/ProtonMail/go-crypto/openpgp. Remove use of deprecated github.com/satori/go.uuid module.

Merge 3.8.3 changelog / install.md changes to master

@edytuk edytuk changed the title Enable staticcheck Linter, from sylabs 283 Enable staticcheck Linter, replace golang.org/x/crypto/ssh/terminal, upgrade to SIF v2, from sylabs 283, 296, 112 Oct 26, 2021
@edytuk edytuk requested a review from DrDaveD October 26, 2021 13:16
@edytuk edytuk changed the title Enable staticcheck Linter, replace golang.org/x/crypto/ssh/terminal, upgrade to SIF v2, from sylabs 283, 296, 112 Enable staticcheck Linter, replace golang.org/x/crypto/ssh/terminal, upgrade to SIF v2, merge 3.8.3 changelog / install.md changes to master, from sylabs 283, 296, 112, 305 Nov 1, 2021
@DrDaveD
Copy link
Collaborator

DrDaveD commented Nov 1, 2021

Rather than a merge, please do git rebase master and then do a force push with git push -f. That reduces the number of commits.

@edytuk edytuk closed this Nov 16, 2021
@edytuk edytuk reopened this Nov 16, 2021
@edytuk edytuk changed the base branch from master to release-3.8 November 16, 2021 12:36
@edytuk edytuk changed the base branch from release-3.8 to master November 16, 2021 12:36
@edytuk edytuk closed this Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants