oci: fix --home when running as root or fakeroot #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrudg
approved these changes
Apr 10, 2023
preminger
pushed a commit
to preminger/singularity
that referenced
this pull request
Apr 14, 2023
preminger
pushed a commit
that referenced
this pull request
Apr 14, 2023
This was referenced Apr 24, 2023
edytuk
pushed a commit
to vzokay/apptainer
that referenced
this pull request
Jun 19, 2023
…1530) Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk
pushed a commit
to vzokay/apptainer
that referenced
this pull request
Jul 4, 2023
…1530) Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk
pushed a commit
to vzokay/apptainer
that referenced
this pull request
Jul 11, 2023
…1530) Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk
pushed a commit
to vzokay/apptainer
that referenced
this pull request
Jul 21, 2023
…1530) Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
edytuk
pushed a commit
to vzokay/apptainer
that referenced
this pull request
Jul 24, 2023
…1530) Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
Fix
--homefunctionality in OCI-mode, so it works even when running as root (e.g. undersudo) or when running with--fakeroot.This fixes or addresses the following GitHub issues:
Related PRs
#1531 describes a more fundamental change to the way custom /etc/passwd information is handled in singularity, which would reduce the likelihood of problems like the one described here arising in the first place.