oci: Improve testing of overlay cleanup #1678
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
In working on #1659 and #1671 , it emerged that in some scenarios (esp. when running as root), our cleanup of overlay mounts was incomplete. Importantly, that cleanup process intentionally logs errors and proceeds (rather than erroring out), in order to clean up as much as possible even under error conditions; but that means that we can't rely simply on exit codes to detect problems in the cleanup of overlay mounts.
This PR adds an e2e test specifically dedicated to detecting such problems, by running an OCI-mode container as root, and comparing the number of current mounts before & after the run.