fix mount home=no
, support --no-home
in --oci
mode
#1784
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
fix: set correct $HOME in --oci mode when mount home = no
When
mount home = no
is set insingularity.conf
, we still need toset the correct value for
$HOME
in the container... we just don'twant to mount it.
Fixes #1783
support
--no-home
in--oci
modeWhen
--no-home
is set on the CLI in--oci
mode, do not mountonto the container home directory.
Fixes #1780
Before submitting a PR, make sure you have done the following:
make check
and tested this PR locally with amake test
, andmake testall
if possible (see CONTRIBUTING.md).