fix mount home=no, support --no-home in --oci mode
#1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `mount home = no` is set in `singularity.conf`, we still need to set the correct value for `$HOME` in the container... we just don't want to mount it. Fixes sylabs#1783
dtrudg
added
bug
When `--no-home` is set on the CLI in `--oci` mode, do not mount onto the container home directory. Fixes sylabs#1780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
fix: set correct $HOME in --oci mode when mount home = no
When
mount home = nois set insingularity.conf, we still need toset the correct value for
$HOMEin the container... we just don'twant to mount it.
Fixes #1783
support
--no-homein--ocimodeWhen
--no-homeis set on the CLI in--ocimode, do not mountonto the container home directory.
Fixes #1780
Before submitting a PR, make sure you have done the following:
make checkand tested this PR locally with amake test, andmake testallif possible (see CONTRIBUTING.md).