cgroups v2 support (apply from v1 / OCI spec) #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrudg
force-pushed
the
cgroups-v2
branch
11 times, most recently
from
7f5d874
to
2f731cc
Compare
This was referenced Aug 31, 2021
Support execution on a cgroups v2 unified hierarchy system, by using the `containerd/cgroups/v2` translation of the `opencontainers/runtime-spec` `LinuxResources` structure (which we use for cgroups config toml files) into v2 Resources. Device limits are implemented with the eBPF translation. This will mean that existing v1 / OCI style cgroups configuration files can be used on a system configured for the unified hierarchy without an ugly failure. Also fixes failures with the `oci` commands on these systems. Note that we don't yet support the Unified attribute from LinuxResources, which is a free-form map[string][string] for expressing cgroups v2 configuration natively. Fixes #60
This was referenced Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
Support execution on a cgroups v2 unified hierarchy system, by using the
containerd/cgroups/v2translation of theopencontainers/runtime-specLinuxResourcesstructure (which we use for cgroups config toml files) into v2 Resources. Device limits are implemented with the eBPF translation.This will mean that existing v1 / OCI style cgroups configuration files can be used on a system configured for the unified hierarchy without an ugly failure. Also fixes failures with the
ocicommands on these systems.Note that we don't yet support the Unified attribute from LinuxResources, which is a free-form map[string][string] for
expressing cgroups v2 configuration natively.
NOTE CircleCI will not test the new cgroups v2 code as it running Ubuntu 20.04 with the cgroups v1 hierarchy. I have run the tests on Debian 11 and Fedora 34, both of which use the cgroups v2 unified hierarchy.
This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make checkand tested this PR locally with amake test, andmake testallif possible (see CONTRIBUTING.md).