Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right edge of Next button disappears #150

Closed
mhagnumdw opened this issue May 23, 2019 · 6 comments
Closed

Right edge of Next button disappears #150

mhagnumdw opened this issue May 23, 2019 · 6 comments
Labels

Comments

@mhagnumdw
Copy link
Contributor

Peek 2019-05-23 13-29

@sylhare sylhare added the bug label May 23, 2019
@sylhare
Copy link
Owner

sylhare commented May 23, 2019

Hi Thanks so much for reporting the bugs. I am surprised for this one, it did not show on my browser.
Which one are you using?

@mhagnumdw
Copy link
Contributor Author

Hi!

SO: Fedora 28
Browser: Chrome 73.0.3683.103 (Official Build) (64-bit)

Animation down showing the screen resolution (Chrome):
Peek 2019-05-23 16-13

Note: Firefox 61.0.2 (64-bit) no problem.

@sylhare
Copy link
Owner

sylhare commented May 23, 2019

Ah I see why I missed it, I use Firefox for dev.

@kaleid-liner
Copy link

This bug happens on chrome when width >= 769. It seems the right fa-icon will overlap the right edge of the button. I use span to enclose the content of button as a workaround. I mean:

<span>
     {{ site.theme_settings.str_next_page }}
     <i class="fa fa-chevron-right"></i>
</span>

@sylhare
Copy link
Owner

sylhare commented Jun 3, 2019

Thanks! That will help me troubleshoot and find a fix.

@sylhare sylhare closed this as completed in a177768 Jun 4, 2019
@sylhare
Copy link
Owner

sylhare commented Jun 4, 2019

It should be all good now. The issue was because of the css of the .button:

display: inline-block;

Basically inline-block takes the whole component while the inline was considering only the text it seemed in some browser. If you still have the issue let me know.

OMEGA-Y pushed a commit to OMEGA-Y/OMEGA-Y.github.io that referenced this issue Dec 8, 2020
* [Docs] Add missing language GH issue links
* [Docs] Add missing languages to sidebar
* [Docs] Check GH issue tracking checkbox
* [Docs] Fix unneeded closing sign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants