Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization for months #245

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Localization for months #245

merged 2 commits into from
Feb 18, 2021

Conversation

danisztls
Copy link
Contributor

I wrote localization strings for months and adapted the post_info code to allow post date to be easily displayed in other languages. Should display the same for the default (english).

@sylhare
Copy link
Owner

sylhare commented Feb 18, 2021

Alright that's cool! Let me test it out 👍
It fits with #241 that was stalled a bit.

Copy link
Owner

@sylhare sylhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job there!
I am being fancy with the review, but the work is very appreciated 👌

_includes/post_info.html Outdated Show resolved Hide resolved
_data/language.yml Outdated Show resolved Hide resolved
@sylhare sylhare merged commit 9cb4af1 into sylhare:master Feb 18, 2021
@danisztls danisztls deleted the localization branch February 19, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants