Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated FontAwesome to 5.15.2 and made the changes needed #246

Merged
merged 5 commits into from
Feb 19, 2021

Conversation

danisztls
Copy link
Contributor

No description provided.

@sylhare
Copy link
Owner

sylhare commented Feb 18, 2021

That's a lot of work on this one, I'll review it as well. Thanks!
How did you proceed to update the it to 5.15.2?

Also out of curiosity, do you know why the fa has been replaced by fas, far, fab? Maybe I should go read about the differences between v4 and v5.

@danisztls
Copy link
Contributor Author

They splitted the icons in different fonts: solid, regular and brands. FA 4 had 675 icons, FA 5.15.2 have 1609 free icons and 7865 pro icons.

About how I proceeded. I did a similar update in December 2019 but did not made a PR at the time so I had an idea of what to do. I screened the theme files to understand how you implemented and the FA documentation to see what should divert from it or could be improved. I deleted the old FA .scss and fonts from the repo and copied the 5.15.2 in the place. As syntax slighted changed I had to replace fa accordingly by [fas,far,fab]. I used ripgrep to find the files that I had do edit and in some used vim/sed to search and replace the strings. Then tested to see if I missed something.

I though on using svg sprites instead of the fonts, as I did in the past but that would divert a lot more from what was currently being used and require an additional JS script to be loaded.

@sylhare sylhare self-requested a review February 18, 2021 15:25
Copy link
Owner

@sylhare sylhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also some icons might have been missed as they are not rendering for me.

For example far fa-file-text:
image

Also, the share icons seems to still have fa like the facebook one fa fa-facebook-square fa-2x causing them I suppose to not be rendered.
image

_includes/post_info.html Outdated Show resolved Hide resolved
@danisztls
Copy link
Contributor Author

Fixed those.

Screenshot from 2021-02-18 15-24-28

Screenshot from 2021-02-18 15-24-41

@danisztls
Copy link
Contributor Author

For documentation purposes.

@danisztls danisztls requested a review from sylhare February 18, 2021 23:13
@sylhare
Copy link
Owner

sylhare commented Feb 19, 2021

Nice thanks 👌

@sylhare sylhare merged commit 56af556 into sylhare:master Feb 19, 2021
@danisztls danisztls deleted the fontawesome5 branch February 19, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants