-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated FontAwesome to 5.15.2 and made the changes needed #246
Conversation
That's a lot of work on this one, I'll review it as well. Thanks! Also out of curiosity, do you know why the |
They splitted the icons in different fonts: solid, regular and brands. FA 4 had 675 icons, FA 5.15.2 have 1609 free icons and 7865 pro icons. About how I proceeded. I did a similar update in December 2019 but did not made a PR at the time so I had an idea of what to do. I screened the theme files to understand how you implemented and the FA documentation to see what should divert from it or could be improved. I deleted the old FA I though on using svg sprites instead of the fonts, as I did in the past but that would divert a lot more from what was currently being used and require an additional JS script to be loaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For documentation purposes. |
Nice thanks 👌 |
No description provided.