Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet/desktop] task: unit tests added for Mnemonic and MosaicAmountDisplay components #1905

Merged

Conversation

OlegMakarenko
Copy link
Contributor

Added tests for:

  • MnemonicDisplay
  • MnemonicVerification
  • MnemonicInput
  • MosaicAmountDisplay

__tests__/components/MnemonicInput.spec.ts Outdated Show resolved Hide resolved
__tests__/components/MnemonicInput.spec.ts Outdated Show resolved Hide resolved
__tests__/components/MnemonicInput.spec.ts Outdated Show resolved Hide resolved
__tests__/components/MnemonicInput.spec.ts Outdated Show resolved Hide resolved
__tests__/components/MnemonicInput.spec.ts Show resolved Hide resolved
__tests__/components/MnemonicInput.spec.ts Show resolved Hide resolved
__tests__/components/MnemonicInput.spec.ts Outdated Show resolved Hide resolved
__tests__/components/MosaicAmountDisplay.spec.ts Outdated Show resolved Hide resolved
__tests__/components/MosaicAmountDisplay.spec.ts Outdated Show resolved Hide resolved
Comment on lines +69 to +73
const expectations = {
initInputToBeCalled: true,
inputWordValue: '',
finalIsEditingValue: true,
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move expectations here and in tests below down to //Act + Assert group

@OlegMakarenko OlegMakarenko merged commit 432b98b into feature/unit-tests-united-2 Oct 3, 2022
@OlegMakarenko OlegMakarenko deleted the feature/unit-tests-mnemonic-rebased branch October 3, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants