feat: node list ordering[random, natural] added #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default order is random when the limit parameter is specified otherwise falls back to natural.
| { filter, limit, order }: NodeSearchCriteria = { filter: {}, limit: 0, order: NodeListOrder.Random }, | ||
| ): Promise<NodeDocument[]> => { | ||
| if (limit > 0 && order === NodeListOrder.Random) { | ||
| return Node.aggregate([{ $match: { ...filter } }, { $sample: { size: limit } }]).exec(); |
There was a problem hiding this comment.
Are we sure that the $sample will not return the same document more than once in the result set?
There was a problem hiding this comment.
Yes =>
https://docs.mongodb.com/manual/reference/operator/aggregation/sample/
WiredTiger or in-memory storage engine, $sample does not return duplicate documents. WiredTiger is the default storage engine as of MongoDB 3.2.
rg911
approved these changes
Nov 18, 2021
AnthonyLaw
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default order is random when the limit parameter is specified otherwise falls back to natural.
partly fixes #103