[statistics-service] fix: websocket connection leak fixed #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yilmazbahadir
requested review from
0x6861746366574,
gimre-xymcity and
Jaguar0625
Jaguar0625
reviewed
Jun 2, 2022
src/utils.ts
Outdated
| const timer = new TimeoutTimer(timeout, timeoutVal, logger, loggingMethod); | ||
| const result = await Promise.race([promise, timer.start()]); | ||
|
|
||
| if (result !== timeoutVal) { |
There was a problem hiding this comment.
while probably fine in this case/project, you're making assumptions of what promises could return. is it possible to call timer.stop unconditionally instead?
There was a problem hiding this comment.
is it possible to call timer.stop unconditionally instead?
Yes, it wouldn't hurt to stop the timer in any case, updated 👍
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.5 to 1.15.1. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.5...v1.15.1) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
yilmazbahadir
force-pushed
the
fix/socket-connection-leak
branch
from
64bc664
to
e007411
Compare
Jaguar0625
approved these changes
Jun 6, 2022
This was referenced Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the issue?
statistics-service server.What's the fix?