Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Command:SUCCESS constant for command exit code when possible #664

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

Chi-teck
Copy link

This is follow-up for symfony/symfony#35431

It would also align generated code with an example in the documentation.
https://symfony.com/doc/current/console.html#creating-a-command

@lyrixx
Copy link
Member

lyrixx commented Aug 24, 2020

Thanks for your first PR 🎉

For what is worth, I prefer to read 0 (It's the same for HTTP Status Code).
More over I would keep the code simpler.

But let's wait for feedback from other contributor :)

@weaverryan
Copy link
Member

Ah, cool! It's subjective, but I like this. And I noticed in the original PR that Javier git a lot of +1's when he said he liked the idea. So let's do it! Thanks @Chi-teck!

@weaverryan weaverryan merged commit 317e137 into symfony:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants