Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix we we typo #973

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Fix we we typo #973

merged 1 commit into from
Sep 17, 2021

Conversation

karser
Copy link
Contributor

@karser karser commented Sep 15, 2021

No description provided.

Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @karser for catching this and submitting the PR!

@jrushlow jrushlow added the Status: Reviewed Has been reviewed by a maintainer label Sep 17, 2021
@weaverryan
Copy link
Member

Thanks Dmitrii!

@weaverryan weaverryan merged commit 93d7cdb into symfony:main Sep 17, 2021
@jrushlow jrushlow mentioned this pull request Sep 24, 2021
weaverryan added a commit that referenced this pull request Sep 27, 2021
This PR was merged into the 1.0-dev branch.

Discussion
----------

[release] prep 1.34.0

# Release
Hi Makers!

This release contains a few new features, fixes, and improvements under the hood! Most notably, this release introduces PHP Attribute support for `make:entity` including entities using API Platform, support for the new Symfony Password Hasher in `make:reset-password`, & `make:registration`, and implements stronger return types where possible.

Diff: v1.33.0...v1.34.0

Happy making!

# Changelog

## [v1.34.0](https://github.com/symfony/maker-bundle/releases/tag/v1.34.0)

*September 27th, 2021*

### Feature

- [#978](#978) - Adding Entity attribute support - *`@simonmarx`*, *`@geekimo`*, *`@adlpz`*, *`@weaverryan`*, *`@jrushlow`*
- [#970](#970) - make PhpCompatUtil::getPhpVersion() public - *`@nikophil`*
- [#968](#968) - [make:entity] APIP: use new attribute if exists - *`@nikophil`*
- [#963](#963) - add return types for symfony 6 - *`@jrushlow`*
- [#925](#925) - [templates] Add void return types - *`@seb`-jean*
- [#923](#923) - use password hasher for make:registration & make:reset-password, includes other improvements - *`@jrushlow`*

### Bug Fix

- [#974](#974) - Fix method call definition - *`@ajgarlag`*
- [#973](#973) - Fix we we typo - *`@karser`*
- [#933](#933) - [make:entity] Remove deprecated json_array type from available list types. - *`@bdaler`*
- [#930](#930) - Add all missed dependencies to make:reset-password - *`@upyx`*
- [#870](#870) - [make:crud] Fix templates path use in include - *`@leblanc`-simon*

Commits
-------

2ba83b3 [release] prep 1.34.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants