Explaining "visible" as within the scrollarea #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe this information could be merged with "Accessing To Hidden Text" into a new heading?
dunglas
requested changes
Jul 12, 2021
| @@ -120,6 +120,8 @@ echo $crawler->filter('#installing-the-framework')->text(); | |||
| $client->takeScreenshot('screen.png'); // Yeah, screenshot! | |||
| ``` | |||
|
|
|||
| "visible" means that the text is within the current scroll area. To check content further down on the page, you can adjust the window size (see below). | |||
There was a problem hiding this comment.
This is actually a bit more complex than that: https://www.w3.org/TR/webdriver/#element-displayedness
Maybe can we just point to the spec?
There was a problem hiding this comment.
Sorry, I don't understand what their bottom line is :-(
Please decide yourself. My point was to give some explanation (or hint at least) if "visible" just means "present in the source code" or "actually displayed on the current screen".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this information could be merged with "Accessing To Hidden Text" into a new heading?