minor: More cleanups and type declarations for v2 #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
force-pushed
the
more-types
branch
10 times, most recently
from
33854ac
to
45983fe
Compare
dunglas
approved these changes
Nov 30, 2021
chalasr
force-pushed
the
more-types
branch
3 times, most recently
from
280f278
to
dfef4ad
Compare
chalasr
added a commit
that referenced
this pull request
Dec 2, 2021
…nitialization (kbond) This PR was merged into the 2.0.x-dev branch. Discussion ---------- Fix accessing `PantherTestCaseTrait::$webServerDir` before initialization `PantherTestCaseTrait::getWebServerDir()` can access `PantherTestCaseTrait::$webServerDir` before it's initialized. I believe this was just missed in #517. Commits ------- 39efc06 fix "webServerDir must not be accessed before initialization"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes support for Symfony 4.4 (1.x supports it).