fix: ignore curl exceptions when closing webdriver inside destructor #565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curl exceptions when quitting WebDriver are being thrown for different reasons, but are hard to handle since the method is called from inside the destructor.
The destructor is called when we are done with WebDriver anyway, and if there is an error quitting (most likely because WebDriver is not responding) we can safely ignore it IMO.
The try/catch is placed on purpose on the destructor only and not in the quit method so that when calling quit manually the exception can still be handled by the caller.