Skip to content

Commit

Permalink
Merge branch '6.0' into 6.1
Browse files Browse the repository at this point in the history
* 6.0:
  CS fixes
  Bump Symfony version to 6.0.11
  Update VERSION for 6.0.10
  Update CHANGELOG for 6.0.10
  Bump Symfony version to 5.4.11
  Update VERSION for 5.4.10
  Update CHANGELOG for 5.4.10
  Bump Symfony version to 4.4.44
  Update VERSION for 4.4.43
  Update CONTRIBUTORS for 4.4.43
  Update CHANGELOG for 4.4.43
  • Loading branch information
nicolas-grekas committed Jun 27, 2022
2 parents 3187184 + 44270a0 commit a6506e9
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions ExecutableFinder.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ public function addSuffix(string $suffix)
*/
public function find(string $name, string $default = null, array $extraDirs = []): ?string
{
if (ini_get('open_basedir')) {
$searchPath = array_merge(explode(\PATH_SEPARATOR, ini_get('open_basedir')), $extraDirs);
if (\ini_get('open_basedir')) {
$searchPath = array_merge(explode(\PATH_SEPARATOR, \ini_get('open_basedir')), $extraDirs);
$dirs = [];
foreach ($searchPath as $path) {
// Silencing against https://bugs.php.net/69240
Expand Down
2 changes: 1 addition & 1 deletion Pipes/AbstractPipes.php
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ protected function write(): ?array
stream_set_blocking($input, 0);
} elseif (!isset($this->inputBuffer[0])) {
if (!\is_string($input)) {
if (!is_scalar($input)) {
if (!\is_scalar($input)) {
throw new InvalidArgumentException(sprintf('"%s" yielded a value of type "%s", but only scalars and stream resources are supported.', get_debug_type($this->input), get_debug_type($input)));
}
$input = (string) $input;
Expand Down
2 changes: 1 addition & 1 deletion ProcessUtils.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public static function validateInput(string $caller, mixed $input): mixed
if (\is_string($input)) {
return $input;
}
if (is_scalar($input)) {
if (\is_scalar($input)) {
return (string) $input;
}
if ($input instanceof Process) {
Expand Down
14 changes: 7 additions & 7 deletions Tests/ExecutableFinderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ private function setPath($path)

public function testFind()
{
if (ini_get('open_basedir')) {
if (\ini_get('open_basedir')) {
$this->markTestSkipped('Cannot test when open_basedir is set');
}

Expand All @@ -51,7 +51,7 @@ public function testFind()

public function testFindWithDefault()
{
if (ini_get('open_basedir')) {
if (\ini_get('open_basedir')) {
$this->markTestSkipped('Cannot test when open_basedir is set');
}

Expand All @@ -67,7 +67,7 @@ public function testFindWithDefault()

public function testFindWithNullAsDefault()
{
if (ini_get('open_basedir')) {
if (\ini_get('open_basedir')) {
$this->markTestSkipped('Cannot test when open_basedir is set');
}

Expand All @@ -82,7 +82,7 @@ public function testFindWithNullAsDefault()

public function testFindWithExtraDirs()
{
if (ini_get('open_basedir')) {
if (\ini_get('open_basedir')) {
$this->markTestSkipped('Cannot test when open_basedir is set');
}

Expand All @@ -105,7 +105,7 @@ public function testFindWithOpenBaseDir()
$this->markTestSkipped('Cannot run test on windows');
}

if (ini_get('open_basedir')) {
if (\ini_get('open_basedir')) {
$this->markTestSkipped('Cannot test when open_basedir is set');
}

Expand All @@ -122,7 +122,7 @@ public function testFindWithOpenBaseDir()
*/
public function testFindProcessInOpenBasedir()
{
if (ini_get('open_basedir')) {
if (\ini_get('open_basedir')) {
$this->markTestSkipped('Cannot test when open_basedir is set');
}
if ('\\' === \DIRECTORY_SEPARATOR) {
Expand All @@ -140,7 +140,7 @@ public function testFindProcessInOpenBasedir()

public function testFindBatchExecutableOnWindows()
{
if (ini_get('open_basedir')) {
if (\ini_get('open_basedir')) {
$this->markTestSkipped('Cannot test when open_basedir is set');
}
if ('\\' !== \DIRECTORY_SEPARATOR) {
Expand Down
2 changes: 1 addition & 1 deletion Tests/NonStopableProcess.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ function handleSignal($signal)
$name = match ($signal) {
\SIGTERM => 'SIGTERM',
\SIGINT => 'SIGINT',
default => $signal . ' (unknown)',
default => $signal.' (unknown)',
};

echo "signal $name\n";
Expand Down
2 changes: 1 addition & 1 deletion Tests/ProcessTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -1131,7 +1131,7 @@ public function testTermSignalTerminatesProcessCleanly()
public function responsesCodeProvider()
{
return [
//expected output / getter / code to execute
// expected output / getter / code to execute
// [1,'getExitCode','exit(1);'],
// [true,'isSuccessful','exit();'],
['output', 'getOutput', 'echo \'output\';'],
Expand Down

0 comments on commit a6506e9

Please sign in to comment.