[Encore] Changing dev-server to use the new server option #16833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
May 31, 2022
|
|
||
| Encore uses ``webpack-dev-server`` version 4, which at the time of Encore's | ||
| 1.0 release was still in beta and was not documented. See the `4.0 CHANGELOG`_ | ||
| for changes. |
There was a problem hiding this comment.
Removed as the note was pretty old now
| } | ||
| }) | ||
| ; | ||
|
|
||
| .. versionadded:: 0.28.4 | ||
|
|
||
| The ``Encore.configureDevServerOptions()`` method was introduced in Encore 0.28.4. |
There was a problem hiding this comment.
That version is now very old, so just some housekeeping
|
|
||
| Make sure to **not** pass the ``--https`` flag at the command line when | ||
| running ``encore dev-server``. This flag was required before 1.0, but now | ||
| will cause your config to be overridden. |
There was a problem hiding this comment.
The first part of the note is now quite old as 1.0 was released about 2 years ago. For the second part (about overridden), I can't find anything in the code that would suggest that also passing --https would cause any type of overriding.
|
Thank you Ryan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: symfony/webpack-encore#1125
But it is NOT dependent on that PR. These changes are already "good change" and do not require changes to Encore.