Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emoji][String] Extract Emoji from String documentation #20216

Merged

Conversation

MrYamous
Copy link
Contributor

Give a try for #20114

I've mainly copy/paste current documentation, with following changes :

  • change name for internal ref link (remove string part)
  • remove a versionadded directive for Inverse Emoji Transliteration (Emoji component was added in 7.1, I think it's not necessary to indicate this feature has been add in 7.1 too)
  • remove Gitlab and Slack example for transliterating services emojis as short code and replace it with a note to mention which services are available
  • add a sentence about slug emojis as this part stay in String documentation

@javiereguiluz javiereguiluz force-pushed the emoji-string-documentation-separation branch from 500504b to 2e11836 Compare September 19, 2024 15:24
@javiereguiluz javiereguiluz merged commit 8323695 into symfony:7.1 Sep 19, 2024
2 of 3 checks passed
@javiereguiluz
Copy link
Member

Matthieu, thanks a lot for the time taken to extract the docs. While merging I re-added the sections about GitLab and Slack transliteration. I agree that they are a bit repetitive, but showing only the GitHub example would make some folks angry because they prefer other services. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants