Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cookbook][Configuration] documentation of Apache + PHP-FPM #3915

Merged
merged 1 commit into from
Aug 16, 2014

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 7, 2014

Q A
Doc fix? no
New docs? yes
Applies to all
Fixed tickets #3749

<Directory /var/www/project/web>
# enable the .htaccess rewrites
AllowOverride All
Require all granted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be Order allow,deny for Apache 2.2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it in the example below.

@weaverryan
Copy link
Member

@xabbuh I added a few suggestions, but this is really nice work.

@weaverryan
Copy link
Member

Thanks for the lightning fast tweaks!

@weaverryan weaverryan merged commit 822b3bd into symfony:2.3 Aug 16, 2014
weaverryan added a commit that referenced this pull request Aug 16, 2014
…-FPM (xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Cookbook][Configuration] documentation of Apache + PHP-FPM

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | all
| Fixed tickets | #3749

Commits
-------

822b3bd document the usage of PHP-FPM on Apache
@xabbuh
Copy link
Member Author

xabbuh commented Aug 16, 2014

@weaverryan I'm sorry, but I didn't address all your suggestions yet. I will submit a new pull request addressing the rest of them.

@xabbuh xabbuh deleted the issue-3749 branch August 16, 2014 19:50
@weaverryan
Copy link
Member

@xabbuh Ah, I thought you had - my mistake! Thanks for continuing with a new PR.

weaverryan added a commit that referenced this pull request Aug 22, 2014
…figuration chapter (xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Cookbook][Configuration] tweaks for the web server configuration chapter

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | all
| Fixed tickets |

Tweaks to #3915 as suggested by @weaverryan.

Commits
-------

93bbd14 tweaks for the web server configuration chapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants