Added a new "Deploying to Heroku Cloud" cookbook article #4045
Conversation
javiereguiluz
commented
Jul 23, 2014
javiereguiluz
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | master |
| Fixed tickets | - |
|
It should also be added to |
| ========================= | ||
|
|
||
| This step by step cookbook describes how to deploy a Symfony2 web application to | ||
| the Heroku cloud platform. Its contents are based on `this original article`_ |
There was a problem hiding this comment.
I would say "the original article"
|
@wouterj thanks for your exhaustive review. Awesome work as always! Regarding the contents of this tutorial, I'd like to add two things:
|
javiereguiluz
changed the title
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Deploying a Symfony2 application to Heroku doesn't require any change in its | ||
| code, but it requires some minor tweaks in its configuration. |
There was a problem hiding this comment.
"[...] tweaks to its configuration"?
|
@xabbuh thanks for your great review! I've applied each and every suggestion. |
|
@javiereguiluz Thanks for this great article. I'll try to review the rest of it later today. |
| Deploying your Application on Heroku | ||
| ------------------------------------ | ||
|
|
||
| To deploy your application to Heroku, you must first create a ``Procfile``, |
There was a problem hiding this comment.
Is this really called "Procfile" and not "Profile"?
There was a problem hiding this comment.
@xabbuh I know that Procfile sounds awful, but I've checked it again and it's definitely the correct name in this context :)
There was a problem hiding this comment.
@javiereguiluz Thanks for clarifying. :)
| Vendor binaries are usually installed to ``vendor/bin`` by Composer, but | ||
| sometimes (e.g. when running a Symfony Standard Edition project!), the | ||
| location will be different. If in doubt, you can always run | ||
| ``composer config bin-dir`` to figure out the right location. |
There was a problem hiding this comment.
Isn't this note misleading since you already wrote in the list before that the bin dir is bin/?
There was a problem hiding this comment.
I should probably reword the text to simplify it. Any suggestions to do it? Thanks!
There was a problem hiding this comment.
I'm ok with this, but we can open a new PR if some better wording comes to us. I kind of like the discussion about how the SE differs from the default.
|
Great job Javier! I loved reading through this! I only had one comment. |
|
Merged! This is so great - thanks Javier! I'd like to see more of these things, especially if we can partner we're avoiding duplication (e.g. if Heroku knows they can suggest any changes/improvements here and link to these docs instead of creating their own). And if there are docs elsewhere (e.g. Capifony), we could still have these, but link out to those docs (and help improve them). Anyways, thanks! |
|
@javiereguiluz I really appreciate that you want to give credits to the reviewers, but could you please remove the mention (the |
|
I'm really sorry Wouter. Excuse me for the noise :( I'll try really hard to not doing it again. However, I'm so used to it, that I could mistakenly do it again in the future. I apologize in advance :) |
|
@javiereguiluz don't worry too much :) |
