Don't register the class_exists loader
#23420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now done when the container boots in Symfony 3.3.x.
| @@ -20,10 +19,6 @@ | |||
| // Enforce a consistent locale | |||
| setlocale(LC_ALL, 'C'); | |||
|
|
|||
| if (!class_exists('Doctrine\Common\Annotations\AnnotationRegistry', false) && class_exists('Doctrine\Common\Annotations\AnnotationRegistry')) { | |||
| AnnotationRegistry::registerLoader('class_exists'); | |||
There was a problem hiding this comment.
To preserve BC, I think we should keep registering this, but add a check in the above if to not do it when 3.3 is in use (dunno which check exactly right now.)
|
I actually think maybe this doesn't matter too much, the fix in doctrine/annotations is the important bit. A lot of my functional tests boot kernels and all of them end up adding |
|
Ok, closing then, thanks for investigating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now done when the container boots in Symfony 3.3.x.
#21837 registers this loader now. Registering it twice is expensive as it gets called a LOT. Especially during tests. In a comparison of Symfony 3.2.10 and 3.3.4 a single test was calling
class_exists90K more times.https://blackfire.io/profiles/compare/0c3627c5-8432-4908-b097-1289b81d63bb/graph
This isn't the best solution, but I'm not sure how to detect the version of Symfony from within the bootstrap.php file so this would be a BC break for any version of Symfony before 3.3.
I also created doctrine/annotations#135
to address this, but wanted to cover all bases.