Skip to content

Commit

Permalink
removing vue2 alias to use the full build
Browse files Browse the repository at this point in the history
  • Loading branch information
weaverryan committed May 10, 2020
1 parent 40f8ae8 commit ebdbebe
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 7 deletions.
21 changes: 21 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,26 @@
# CHANGELOG

## 0.30.0

* [BC BREAK] The Vue "build" was changed from `vue.esm.js` (full build) to
`vue.runtime.esm.js` (runtime build). With the runtime build, there are
two things that you cannot do:

A) You cannot pass a string to `template`:

```js
```

B) You cannot mount to a DOM element and use its HTML as your template:

```js
new Vue({
el: '#app', // where <div id="app"> contains your Vue template
});
```

If you need this behavior, call `Encore.addAliases({ vue$: 'vue/dist/vue.esm.js' });`

## 0.29.0

* Support for Node 8 was dropped.
Expand Down
7 changes: 0 additions & 7 deletions lib/config-generator.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,6 @@ class ConfigGenerator {
alias: {}
};

if (this.webpackConfig.useVueLoader) {
const vueVersion = getVueVersion(this.webpackConfig);
if (vueVersion === 2) {
config.resolve.alias['vue$'] = 'vue/dist/vue.esm.js';
}
}

if (this.webpackConfig.usePreact && this.webpackConfig.preactOptions.preactCompat) {
config.resolve.alias['react'] = 'preact-compat';
config.resolve.alias['react-dom'] = 'preact-compat';
Expand Down

0 comments on commit ebdbebe

Please sign in to comment.