Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional tests should intercept the output #47

Closed
stof opened this issue Jun 21, 2017 · 1 comment · Fixed by #143
Closed

Functional tests should intercept the output #47

stof opened this issue Jun 21, 2017 · 1 comment · Fixed by #143

Comments

@stof
Copy link
Member

stof commented Jun 21, 2017

The output of the command running in functional tests should not be sent to the test runner output.
@weaverryan
Copy link
Member

+1 these are coming from FriendlyErrorsWebpackPlugin. I'd prefer not to disable this in the test environment (to keep the functional tests realistic) - I'd like to find a different solution.

Lyrkan added a commit to Lyrkan/webpack-encore that referenced this issue Aug 18, 2017
@Lyrkan
Intercept output during functional tests (fixes symfony#47)
a74869b
@Lyrkan Lyrkan mentioned this issue Aug 18, 2017
Merged
weaverryan added a commit that referenced this issue Sep 2, 2017
@weaverryan
minor #143 Intercept Webpack output during functional tests (Lyrkan)
1c98c9c 
This PR was merged into the master branch.

Discussion
----------

Intercept Webpack output during functional tests

This PR replaces `process.stdout.write` by an empty function when running webpack in each functional test (fixes #47).

It also sets the `silent` option of the Zombie.js browser to true to avoid displaying things like:

```
Download the Vue Devtools extension for a better development experience:
https://github.com/vuejs/vue-devtools
You are running Vue in development mode.
Make sure to turn on production mode when deploying for production.
See more tips at https://vuejs.org/guide/deployment.html
```

The only "noisy" message left should be `DeprecationWarning: Chunk.modules is deprecated. Use Chunk.getNumberOfModules/mapModules/forEachModule/containsModule instead` since it is sent to stderr (should be fixed when alexindigo/webpack-chunk-hash#9 is released).

Commits
-------

a74869b Intercept output during functional tests (fixes #47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Intercept Webpack output during functional tests Lyrkan/webpack-encore
2 participants
@weaverryan @stof