Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay force sync until needed #1175

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Conversation

weaverryan
Copy link
Member

Hi!

This finishes #1155.

Cheers!

@TomaszGasior
Copy link

TomaszGasior commented Feb 17, 2023

I confirm that when I apply change from this PR in my app, error when building assets is resolved: TomaszGasior/RadioLista-v3#218 ("Timed out waiting for sync-rpc server to start (it should respond with "pong" when sent "ping""). However, the thing is: I just don't use Eslint. If I would use Eslint integration, the error would happen again because just the environment I use does not allow to use any random port; I can use only already set up defined ports. The thing inside forceSync function tries to reserve some random port which is not allowed in my environment. It would be nice if the thing you are trying to achieve in this code would be done without requiring usage of random ports. This is not possible in some environments.

(However, I must admit I don't know whether that integration makes sense outside development environment and what it does. If this is only for dev env, then the fix in the PR is just fine.)

TomaszGasior added a commit to TomaszGasior/RadioLista-v3 that referenced this pull request Feb 18, 2023
This commit reverts part of 6ec9eaf

New version of Webpack Encore is not compatible with shared hosting.
symfony/webpack-encore#1154
symfony/webpack-encore#1175

Fixes #218
@weaverryan
Copy link
Member Author

Thanks @wesoledi for your original work :)

@weaverryan weaverryan merged commit b6e6b17 into symfony:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants