Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow eslint-webpack-plugin ^4.0 #1190

Merged

Conversation

evertharmeling
Copy link
Contributor

eslint-webpack-plugin:^4 dropped support for node:12 and eslint:7, this library already is on higher versions ("node": ">=14.0.0" and "eslint": "^8.0.0"), so this should not be a problem.

Or should we still support eslint-webpack-plugin:3 too?

@stof
Copy link
Member

stof commented Feb 28, 2023

This dev dependency should stay compatible with the range allowed in the peer dependency.

And reducing a peer dependency range is a BC break, so support for eslint-webpack-plugin v3 must be kept until the next major version of Encore.

@evertharmeling evertharmeling force-pushed the update-eslint-webpack-plugin branch 3 times, most recently from e007e8e to 8f18ec5 Compare February 28, 2023 11:16
@evertharmeling evertharmeling changed the title Upgraded eslint-webpack-plugin to ^4 Allow eslint-webpack-plugin ^4.0 Feb 28, 2023
@weaverryan
Copy link
Member

Thanks @evertharmeling!

@weaverryan weaverryan merged commit bf51541 into symfony:main Apr 19, 2023
@Kocal Kocal mentioned this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants