Allow eslint-webpack-plugin ^4.0 #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This dev dependency should stay compatible with the range allowed in the peer dependency. And reducing a peer dependency range is a BC break, so support for eslint-webpack-plugin v3 must be kept until the next major version of Encore. |
evertharmeling
force-pushed
the
update-eslint-webpack-plugin
branch
3 times, most recently
from
e007e8e to
8f18ec5
Compare
evertharmeling
changed the title
evertharmeling
force-pushed
the
update-eslint-webpack-plugin
branch
from
8f18ec5 to
f84df0c
Compare
evertharmeling
force-pushed
the
update-eslint-webpack-plugin
branch
from
f84df0c to
441984c
Compare
stof
approved these changes
Feb 28, 2023
|
Thanks @evertharmeling! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint-webpack-plugin:^4dropped support fornode:12andeslint:7, this library already is on higher versions ("node": ">=14.0.0"and"eslint": "^8.0.0"), so this should not be a problem.Or should we still support
eslint-webpack-plugin:3too?