Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the version of stylus used in dev #1334

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Conversation

stof
Copy link
Member

@stof stof commented Sep 7, 2024

This also removes the optional peerDependency on stylus that was using an outdated range because Encore does not actually use stylus in any way but only stylus-loader. And stylus-loader already declares a required peerDependency on stylus, making package managers ensure its presence when stylus-loader is present.

This also removes the optional peerDependency on stylus that was using
an outdated range because Encore does not actually use stylus in any
way but only stylus-loader. And stylus-loader already declares a
required peerDependency on stylus, making package managers ensure its
presence when stylus-loader is present.
@stof stof requested a review from Kocal September 7, 2024 16:30
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like legit, thanks!

@stof stof merged commit 9f31ac1 into symfony:main Sep 7, 2024
28 checks passed
@stof stof deleted the upgrade_stylus branch September 7, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants