Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace assets-webpack-plugin dependency by an internal plugin, to generate entrypoints.json file #1342

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Sep 17, 2024

Q A
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #969
License MIT

This PR replaces the https://github.com/ztoben/assets-webpack-plugin dependency with an internal plugin, this allows us:

Things done in this PR:

  • Re-implement https://github.com/ztoben/assets-webpack-plugin functionality as closely as possible
  • Ensure tests pass without any modifications
  • Ensure the branch works like before on a real project (in dev/prod/dev-server, with or without integrity hashes)

Things not done in this PR:

@Kocal Kocal force-pushed the drop-assets-webpack-plugin branch from 42d8e8d to e3dc0f0 Compare September 17, 2024 19:53
@Kocal Kocal marked this pull request as ready for review September 17, 2024 19:53
Comment on lines +70 to +77
// We don't want to include hot-update files in the manifest
if (asset.name.includes('.hot-update.')) {
continue;
}
Copy link
Member Author

@Kocal Kocal Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you update a file while the dev-server is running, an .hot-update. file can be emitted, but we don't want to add it in the manifest.

@Kocal Kocal force-pushed the drop-assets-webpack-plugin branch from e3dc0f0 to 8b7a463 Compare September 17, 2024 19:55
@Kocal Kocal added this to the 5.0 milestone Sep 17, 2024
@Kocal Kocal requested a review from stof September 17, 2024 20:04
@Kocal Kocal added the Feature New Feature label Sep 17, 2024
@Kocal Kocal force-pushed the drop-assets-webpack-plugin branch from 8b7a463 to 0529865 Compare September 19, 2024 15:41
@Kocal Kocal merged commit b212b15 into symfony:main Sep 20, 2024
28 checks passed
@Kocal Kocal deleted the drop-assets-webpack-plugin branch September 20, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entrypoints integrity workaround needed to allow for assets-webpack-plugin or higher
2 participants